Add ProjectRootCalculator, cleanup PathHelper #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
georgii-borovinskikh-sonarsource
linked an issue
| @@ -45,197 +45,6 @@ public void PathHelper_EscapeFileName() | |||
| actualEscaped.Should().Be(expectedEscaped); | |||
| } | |||
|
|
|||
| [TestMethod] | |||
There was a problem hiding this comment.
The methods tested here were unused, so I removed them and these tests
| @@ -53,83 +53,6 @@ public static string EscapeFileName(string unescapedName) | |||
| return escapedName.ToString(); | |||
| } | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Removed unused methods
| @@ -28,6 +28,7 @@ | |||
| namespace SonarLint.VisualStudio.ConnectedMode | |||
| { | |||
| [Export(typeof(IStatefulServerBranchProvider))] | |||
| // note: this class does not seem to be safe from concurrent updates | |||
There was a problem hiding this comment.
maybe add a ticket to backlog so we can track it.
There was a problem hiding this comment.
ugras-ergun-sonarsource
approved these changes
Nov 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
georgii-borovinskikh-sonarsource
merged commit 1085957
into
feature/mute-server-issues
8 checks passed
ugras-ergun-sonarsource
pushed a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5058