Move & rename the files from Suppression to Synchronization folder #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older Preparation step before replacing IsSuppressed with ServerIssue in IAnalysisIssueVisualization
georgii-borovinskikh-sonarsource
requested review from
ugras-ergun-sonarsource
and removed request for
ugras-ergun-sonarsource
georgii-borovinskikh-sonarsource
changed the title
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -122,13 +122,12 @@ public async Task UpdateFileStorageAsync() | |||
| Debug.Assert(fullSolutionFilePath != null, "Not expecting the solution name to be null in Connected Mode"); | |||
| var solnNameWithoutExtension = System.IO.Path.GetFileNameWithoutExtension(fullSolutionFilePath); | |||
|
|
|||
| var allSuppressedIssues = serverIssuesStore.Get(); | |||
| var allSuppressedIssues = serverIssuesStore.Get().Where(x => x.IsResolved); | |||
There was a problem hiding this comment.
here's a logic change I think this change requires some tests.
There was a problem hiding this comment.
It's covered by the existing tests. I just moved this LINQ call from one place to the other.
|
We decided to go with a different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation step before replacing IsSuppressed with ServerIssue in IAnalysisIssueVisualization
Fixes #5044
Part of #5040