Convert SuppressedIssueMatcher to IssueMatcher, return SonarQubeIssue instead of boolean #5043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of boolean
georgii-borovinskikh-sonarsource
requested a review
from ugras-ergun-sonarsource
| @@ -99,11 +99,11 @@ internal class IssueHandler | |||
| onSnapshotChanged(newSnapshot); | |||
| } | |||
|
|
|||
| private void MarkSuppressedIssues(IEnumerable<IAnalysisIssueVisualization> issues) | |||
| private void MatchServerIssues(IEnumerable<IAnalysisIssueVisualization> issues) | |||
There was a problem hiding this comment.
method name should be "Mark" not "Match" (unless the change is intentional)
There was a problem hiding this comment.
It is intentional. The end goal of this series of PRs is to match the issues instead of just marking them.
ugras-ergun-sonarsource
approved these changes
Nov 23, 2023
|
Kudos, SonarCloud Quality Gate passed! |
georgii-borovinskikh-sonarsource
merged commit 976cd37
into
feature/mute-server-issues
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5042
Part of #5040