SLVSCODE-895 if level not specified, turn the rule ON #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static String safeParseLevel(Map<String, Object> config) { | ||
| Object levelValue = config.get("level"); | ||
| return levelValue instanceof String actualValue ? actualValue : null; | ||
| return levelValue instanceof String actualValue ? actualValue : "on"; |
There was a problem hiding this comment.
Looks good on the functional side, would be even better with a test 😇
sophio-japharidze-sonarsource
force-pushed
the
SLVSCODE-895_default_to_rule_being_on
branch
2 times, most recently
from
93f4727 to
9626d9f
Compare
sophio-japharidze-sonarsource
force-pushed
the
SLVSCODE-895_default_to_rule_being_on
branch
from
9626d9f to
220d1a5
Compare
|
sophio-japharidze-sonarsource
deleted the
SLVSCODE-895_default_to_rule_being_on
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLVSCODE-895