SLLS-207 do not notify backend after assistCreatingConnection #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var newConnectionId = assistCreatingConnectionResponse.getNewConnectionId(); | ||
| if (newConnectionId != null) { | ||
| var serverProductName = isSonarCloud ? "SonarCloud" : "SonarQube"; | ||
| client.showMessage(new MessageParams(MessageType.Info, format("Connection to %s was successfully created.", serverProductName))); | ||
| backendServiceFacade.getBackendService().didChangeConnections(currentConnections); |
There was a problem hiding this comment.
This call was in fact making things worse, as it was "faking" to notifying SLCORE that a connection was added BEFORE it had actually reached SLLS settings storage. SLCORE already has a mechanism that waits for the actual connection creation for 5 seconds.
|
vnaskos-sonar
approved these changes
Oct 14, 2024
sophio-japharidze-sonarsource
deleted the
SLLS-207_assistConnection_hardening
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLLS-207