SONARJAVA-4634 Test for duplicates in credential method json file #5132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
changed the title
There was collision because of wildcard uses, which could have ended up in FPs.
romainbrenguier
force-pushed
the
romain/test-credential-methods
branch
from
629a216 to
9799aad
Compare
To ensure full coverage of the changes.
|
| @@ -7438,7 +7438,7 @@ | |||
| {"cls":"redis.clients.jedis.JedisSentinelPool","name":"JedisSentinelPool","args":["java.lang.String","java.util.Set","*","int","java.lang.String","int","java.lang.String"],"indices":[4]}, | |||
| {"cls":"redis.clients.jedis.JedisSentinelPool","name":"JedisSentinelPool","args":["java.lang.String","java.util.Set","*","int","java.lang.String","java.lang.String","int"],"indices":[5]}, | |||
| {"cls":"redis.clients.jedis.JedisSentinelPool","name":"JedisSentinelPool","args":["java.lang.String","java.util.Set","*","int","java.lang.String","java.lang.String","int","java.lang.String"],"indices":[5]}, | |||
| {"cls":"redis.clients.jedis.JedisSentinelPool","name":"JedisSentinelPool","args":["java.lang.String","java.util.Set","*","java.lang.String"],"indices":[3]}, | |||
| {"cls":"redis.clients.jedis.JedisSentinelPool","name":"JedisSentinelPool","args":["java.lang.String","java.util.Set","org.apache.commons.pool2.impl.GenericObjectPoolConfig","java.lang.String"],"indices":[3]}, | |||
There was a problem hiding this comment.
I think the entry with * that was removed here was covering both line 7441 and line 7443, maybe instead of replacing this entry we could remove line 7443 as it's redundant?
I'm not sure if the intent of these entries is to prevent or to fix, the * approach would cover possible future new signatures, while being more specific with the naming allows to intervene only when needed.
I think we might want an opinion from Hendrik here, as he's the main contributor to this list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-4634
Adding a test for duplicated entries found a few cases where we could have false positives because of wildcard usage.