(DO NOT MERGE) SONARJAVA-4539 Fix FP on S1602 in lambda when curly braces are required to avoid ambiguity #5127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-tylenda-sonarsource
force-pushed
the
tt/S1602-lambda-block
branch
from
843394d to
91feaad
Compare
tomasz-tylenda-sonarsource
force-pushed
the
tt/S1602-lambda-block
branch
from
99c9dd1 to
add1d21
Compare
romainbrenguier
requested changes
May 8, 2025
Comment on lines
93
to
97
| Optional<Arguments> argumentList = Optional.ofNullable(argument.parent()) | ||
| .filter(Arguments.class::isInstance) | ||
| .map(Arguments.class::cast); | ||
|
|
||
| if(argumentList.isPresent()) { |
There was a problem hiding this comment.
I would prefer if (argument.parent() instance of Arguments argumentList) which is more succinct
Comment on lines
99
to
103
| return argumentList | ||
| .map(Tree::parent) | ||
| .filter(MethodInvocationTree.class::isInstance) | ||
| .map(MethodInvocationTree.class::cast) | ||
| .map(mit -> new InvocationData(mit.methodSymbol(), position)); |
There was a problem hiding this comment.
Same thing: if (argumentList.parent() instance MethodInvocationTree mit)
| /** | ||
| * Given a collection of method symbols, get the distinct types possible at {@code position}. | ||
| */ | ||
| private static Stream<Type> getTypesAtPos(Collection<Symbol> symbols, int position) { |
| } | ||
|
|
||
| /** | ||
| * Given a collection of method symbols, get the distinct types possible at {@code position}. |
There was a problem hiding this comment.
this should mention that it's the position among the parameters
romainbrenguier
approved these changes
May 8, 2025
tomasz-tylenda-sonarsource
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-4539