SONARIAC-749: add W8003, adjust the message of E1028 (#659)

SonarSource · May 8, 2023 · 9f7491a · 9f7491a
1 parent e0ff24e
commit 9f7491a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...cloudformation/src/main/resources/org/sonar/l10n/cloudformation/rules/cfn-lint/rules.json b/...cloudformation/src/main/resources/org/sonar/l10n/cloudformation/rules/cfn-lint/rules.json
@@ -290,7 +290,7 @@
       "functions",
       "if"
     ],
-    "description": "Check Fn::If to make sure its valid.  Condition has to be a string.",
+    "description": "Check Fn::If to make sure its valid. Condition has to be a string.",
     "constantDebtMinutes": 0,
     "type": "BUG",
     "severity": "MAJOR"
@@ -1880,6 +1880,18 @@
     "type": "CODE_SMELL",
     "severity": "MAJOR"
   },
+  {
+    "key": "W8003",
+    "name": "'Fn::Equals' will always return true or false",
+    "url": "https://github.com/aws-cloudformation/cfn-lint/blob/main/docs/rules.md#rules-1",
+    "tags": [
+      "conditions"
+    ],
+    "description": "Validate 'Fn::Equals' to see if its comparing two strings or two equal items. While this works it may not be intended.",
+    "constantDebtMinutes": 0,
+    "type": "CODE_SMELL",
+    "severity": "MAJOR"
+  },
   {
     "key": "cfn-lint.fallback",
     "name": "Cfn-lint Rule",

diff --git a/...rmation/src/test/java/org/sonar/iac/cloudformation/plugin/CfnLintRulesDefinitionTest.java b/...rmation/src/test/java/org/sonar/iac/cloudformation/plugin/CfnLintRulesDefinitionTest.java
@@ -38,7 +38,7 @@ void createExternalCfnLintRepository() {
     assertThat(repository.name()).isEqualTo("CFN-LINT");
     assertThat(repository.language()).isEqualTo("cloudformation");
     assertThat(repository.isExternal()).isTrue();
-    assertThat(repository.rules()).hasSize(145);
+    assertThat(repository.rules()).hasSize(146);
   }
 
 }