Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify S3649(Python): Fix logic error #4598

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Modify S3649(Python): Fix logic error #4598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rules/S3649/python/how-to-fix-it/sqlalchemy.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import sqlalchemy
@app.route('/example')
def get_users():
user = request.args["user"]
conn = sqlalchemy.create_engine(connection_string)
engine = sqlalchemy.create_engine(connection_string)
conn = engine.connect()
conn.execute("SELECT user FROM users WHERE user = '" + user + "'") # Noncompliant
Expand All @@ -43,7 +43,7 @@ import sqlalchemy
@app.route('/example')
def get_users():
user = request.args["user"]
conn = sqlalchemy.create_engine(connection_string)
engine = sqlalchemy.create_engine(connection_string)
metadata = sqlalchemy.MetaData(bind=conn, reflect=True)
users = metadata.tables['users']
conn = engine.connect()
Expand Down
Loading