Modify S6327: Improve the recommended fix #4543
Conversation
rules/S6327/recommended.adoc
Outdated
| It's recommended to encrypt SNS topics that contain sensitive information. Encryption and decryption are handled transparently by SNS, so no further modifications to the application are necessary. | ||
| It is recommended to encrypt SNS topics that contain sensitive information. | ||
|
|
||
| To do so, create a master key and affect the SNS topic to it. Without a master |
There was a problem hiding this comment.
Is "affect" the right word here?
rules/S6327/recommended.adoc
Outdated
| It is recommended to encrypt SNS topics that contain sensitive information. | ||
|
|
||
| To do so, create a master key and affect the SNS topic to it. Without a master | ||
| key, the SNS topic is not encrypted by default. |
There was a problem hiding this comment.
Using the negative version is usually a bit harder to understand than the positive version: "With a master key, the SNS topic is encrypted by default".
There was a problem hiding this comment.
I removed it, the goal was to say that by default no encryption applied but I am starting to think this sentence, at this location could be confusing. I replaced it with notable information instead
|
|
Review
A dedicated reviewer checked the rule description successfully for: