Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7159: Replicate API tokens should not be disclosed #4494

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource changed the title Create rule S7159 Create rule S7159: Replicate API tokens should not be disclosed Nov 12, 2024
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource marked this pull request as ready for review November 12, 2024 15:06
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Minor: I suggest adding a little more peculiarities of pushing malicious models; after the data_modification.adoc inclusion

@hendrik-buchwald-sonarsource
Copy link
Contributor

@loris-s-sonarsource I thought about it. It would be helpful. As far as I know, certain model formats are affected by unpickling and, thus, code execution. However, it needs some proper research first to avoid spreading half-truths. Considering the amount of tickets remaining I would suggest that we do it at a later time.

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource merged commit 1d3e50e into master Nov 13, 2024
10 of 11 checks passed
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource deleted the rule/add-RSPEC-S7159 branch November 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants