Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6869: CPU limits should be enforced #3515

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the iac label Dec 19, 2023
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource changed the title Create rule S6869 Create rule S6869: CPU limits should be enforced Dec 19, 2023
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource marked this pull request as ready for review December 19, 2023 15:50
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The comments are just suggestions, this PR is fine to merge either way.

rules/S6869/kubernetes/rule.adoc Show resolved Hide resolved
rules/S6869/kubernetes/rule.adoc Show resolved Hide resolved
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource merged commit 50c8c02 into master Dec 20, 2023
11 checks passed
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource deleted the rule/add-RSPEC-S6869 branch December 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants