Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6865: Service account tokens should not be mounted in pods #3505

Merged
merged 7 commits into from
Dec 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two suggestions


//=== Articles & blog posts
//=== Conference presentations
//=== Standards

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a CWE such as CWE-306 Missing Authentication for Critical Function

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh I do not think that CWE-306 is applicable here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this suggestion based on this CVE: https://nvd.nist.gov/vuln/detail/CVE-2021-41266

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional clarification. I agree with you and I have created a follow up PR: #3516
Maybe you can review it.

@@ -0,0 +1,118 @@
Service account tokens should not be mounted in pods

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a point at the end of the sentence.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I will remove this sentence since it is just duplicating the title.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource marked this pull request as ready for review December 19, 2023 10:51
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource merged commit 7830f4a into master Dec 19, 2023
11 checks passed
@daniel-teuchert-sonarsource daniel-teuchert-sonarsource deleted the rule/add-RSPEC-S6865 branch December 19, 2023 11:38
@daniel-teuchert-sonarsource daniel-teuchert-sonarsource changed the title Create rule S6865 Create rule S6865: Service account tokens should not be mounted in pods Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants