Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S2092, S3330, S4830, S5131, S5144: Revert FastAPI changes #3408

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

egon-okerman-sonarsource
Copy link
Contributor

The PRs #3365, #3374, #3386, #3391 and #3392 were merged before implementation. This reverts them, to be merged only once implemented.

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link

sonarqube-next bot commented Nov 6, 2023

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Nov 6, 2023

Quality Gate passed Quality Gate passed for 'rspec-tools'

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@egon-okerman-sonarsource egon-okerman-sonarsource enabled auto-merge (squash) November 6, 2023 15:58
@egon-okerman-sonarsource egon-okerman-sonarsource merged commit 6417c38 into master Nov 6, 2023
@egon-okerman-sonarsource egon-okerman-sonarsource deleted the egon/revert-fastapi-prs branch November 6, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant