-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Modify Rule S4830: Add aiohttp support (APPSEC-1361) (#3383)
## Review A dedicated reviewer checked the rule description successfully for: - [ ] logical errors and incorrect information - [ ] information gaps and missing content - [ ] text style and tone - [ ] PR summary and labels follow [the guidelines](https://github.com/SonarSource/rspec/#to-modify-an-existing-rule)
- Loading branch information
1 parent
1daf5f7
commit 53c90ee
Showing
2 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
== How to fix it in aiohttp | ||
|
||
=== Code examples | ||
|
||
include::../../common/fix/code-rationale.adoc[] | ||
|
||
:cert_variable_name: verify_ssl | ||
:cert_variable_unsafe_value: False | ||
:cert_variable_safe_value: True | ||
|
||
include::../../common/fix/code-rationale-setting.adoc[] | ||
|
||
==== Noncompliant code example | ||
|
||
[source,python,diff-id=41,diff-type=noncompliant] | ||
---- | ||
import aiohttp | ||
async def example(): | ||
async with aiohttp.ClientSession() as session: | ||
session.get("https://example.com", verify_ssl=False) # Noncompliant | ||
---- | ||
|
||
==== Compliant solution | ||
|
||
[source,python,diff-id=41,diff-type=compliant] | ||
---- | ||
import aiohttp | ||
# By default, certificate validation is enabled | ||
async def example(): | ||
async with aiohttp.ClientSession() as session: | ||
session.get("https://example.com") | ||
---- | ||
|
||
=== How does this work? | ||
|
||
include::../../common/fix/validation.adoc[] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters