Use a better seed source.

SonarSource · Mar 29, 2024 · 2443550 · 2443550
1 parent 85029fc
commit 2443550
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/rules/S4347/csharp/how-to-fix-it/bouncycastle.adoc b/rules/S4347/csharp/how-to-fix-it/bouncycastle.adoc
@@ -77,7 +77,8 @@ sr.NextBytes(random);
 ----
 
 Use unpredictable values to seed `DigestRandomGenerator` and
-`VmpcRandomGenerator` instances.
+`VmpcRandomGenerator` instances. The `SecureRandom.GenerateSeed()` method is
+designed for this purpose.
 
 [source,csharp,diff-id=102,diff-type=compliant]
 ----
@@ -92,7 +93,7 @@ digest.AddSeedMaterial(SecureRandom.GenerateSeed(16));
 digest.NextBytes(random);
 
 IRandomGenerator vmpc = new VmpcRandomGenerator();
-vmpc.AddSeedMaterial(Guid.NewGuid().ToByteArray());
+vmpc.AddSeedMaterial(SecureRandom.GenerateSeed(16));
 vmpc.NextBytes(random);
 ----