Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementation of S109 sonar-no-magic-numbers #4324

Merged
merged 3 commits into from
Oct 30, 2023
Merged

New implementation of S109 sonar-no-magic-numbers #4324

merged 3 commits into from
Oct 30, 2023

Conversation

saberduck
Copy link
Contributor

Fixes #4004

Co-authored-by: Ilia Kebets <104737176+ilia-kebets-sonarsource@users.noreply.github.com>
@saberduck saberduck enabled auto-merge (squash) October 30, 2023 08:09
Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqube-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saberduck saberduck merged commit ffa4380 into master Oct 30, 2023
13 checks passed
@saberduck saberduck deleted the i4004 branch October 30, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve S109 (no-magic-numbers)
2 participants