Fix FP S4662 (at-rule-no-unknown): Ignore "@contain" by default

SonarSource · Oct 26, 2023 · aeebfa2 · aeebfa2
1 parent f600f32
commit aeebfa2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/sonar-plugin/css/src/main/java/org/sonar/css/rules/AtRuleNoUnknown.java b/sonar-plugin/css/src/main/java/org/sonar/css/rules/AtRuleNoUnknown.java
@@ -30,7 +30,7 @@
 public class AtRuleNoUnknown implements CssRule {
 
   private static final String DEFAULT_IGNORED_AT_RULES =
-    "value,at-root,content,debug,each,else,error,for,function,if,include,mixin,return,warn,while,extend,use,forward,tailwind,apply,layer,/^@.*/";
+    "value,at-root,content,debug,each,else,error,for,function,if,include,mixin,return,warn,while,extend,use,forward,tailwind,apply,layer,container,/^@.*/";
 
   @RuleProperty(
     key = "ignoreAtRules",

diff --git a/sonar-plugin/css/src/test/java/org/sonar/css/rules/CssRuleTest.java b/sonar-plugin/css/src/test/java/org/sonar/css/rules/CssRuleTest.java
@@ -149,7 +149,7 @@ void at_rule_unknown_default() {
     String optionsAsJson = new Gson().toJson(new AtRuleNoUnknown().stylelintOptions());
     assertThat(optionsAsJson)
       .isEqualTo(
-        "[true,{\"ignoreAtRules\":[\"value\",\"at-root\",\"content\",\"debug\",\"each\",\"else\",\"error\",\"for\",\"function\",\"if\",\"include\",\"mixin\",\"return\",\"warn\",\"while\",\"extend\",\"use\",\"forward\",\"tailwind\",\"apply\",\"layer\",\"/^@.*/\"]}]"
+        "[true,{\"ignoreAtRules\":[\"value\",\"at-root\",\"content\",\"debug\",\"each\",\"else\",\"error\",\"for\",\"function\",\"if\",\"include\",\"mixin\",\"return\",\"warn\",\"while\",\"extend\",\"use\",\"forward\",\"tailwind\",\"apply\",\"layer\",\"container\",\"/^@.*/\"]}]"
       );
   }
 

diff --git a/...lugin/src/test/java/org/sonar/plugins/javascript/utils/RulesMetadataForSonarLintTest.java b/...lugin/src/test/java/org/sonar/plugins/javascript/utils/RulesMetadataForSonarLintTest.java
@@ -109,7 +109,7 @@ void test() throws Exception {
         "        \"key\": \"ignoreAtRules\",\n" +
         "        \"name\": \"ignoreAtRules\",\n" +
         "        \"description\": \"Comma-separated list of \\\"at-rules\\\" to consider as valid.\",\n" +
-        "        \"defaultValue\": \"value,at-root,content,debug,each,else,error,for,function,if,include,mixin,return,warn,while,extend,use,forward,tailwind,apply,layer,/^@.*/\",\n" +
+        "        \"defaultValue\": \"value,at-root,content,debug,each,else,error,for,function,if,include,mixin,return,warn,while,extend,use,forward,tailwind,apply,layer,container,/^@.*/\",\n" +
         "        \"type\": {\n" +
         "          \"type\": \"STRING\",\n" +
         "          \"values\": [],\n" +
@@ -143,6 +143,7 @@ void test() throws Exception {
         "          \"tailwind\",\n" +
         "          \"apply\",\n" +
         "          \"layer\",\n" +
+        "          \"container\",\n" +
         "          \"/^@.*/\"\n" +
         "        ]\n" +
         "      }\n" +