Tag RSPECs of JS/TS rules relying on type information

SonarSource · Oct 24, 2023 · 25625ad · 25625ad
1 parent 532e623
commit 25625ad
Show file tree

Hide file tree

Showing 74 changed files with 164 additions and 75 deletions.
diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1128.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1128.json
@@ -14,7 +14,8 @@
   },
   "tags": [
     "es2015",
-    "unused"
+    "unused",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1128",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1154.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1154.json
@@ -6,7 +6,9 @@
     "func": "Constant\/Issue",
     "constantCost": "20min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-1154",
   "sqKey": "S1154",

diff --git a/...javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S131.json b/...javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S131.json
@@ -13,7 +13,8 @@
     "constantCost": "5min"
   },
   "tags": [
-    "cwe"
+    "cwe",
+    "type-dependent"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-131",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1874.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1874.json
@@ -14,7 +14,8 @@
   },
   "tags": [
     "cwe",
-    "obsolete"
+    "obsolete",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1874",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2201.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2201.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2201",
   "sqKey": "S2201",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2234.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2234.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2234",
   "sqKey": "S2234",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2259.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2259.json
@@ -13,7 +13,8 @@
     "constantCost": "10min"
   },
   "tags": [
-    "cwe"
+    "cwe",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2259",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2639.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2639.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "15min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2639",
   "sqKey": "S2639",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2692.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2692.json
@@ -13,7 +13,8 @@
     "constantCost": "2min"
   },
   "tags": [
-    "suspicious"
+    "suspicious",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2692",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2817.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2817.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "2h"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-2817",
   "sqKey": "S2817",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2819.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2819.json
@@ -14,7 +14,8 @@
   },
   "tags": [
     "cwe",
-    "html5"
+    "html5",
+    "type-dependent"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2819",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2870.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2870.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2870",
   "sqKey": "S2870",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2871.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2871.json
@@ -13,7 +13,8 @@
     "constantCost": "10min"
   },
   "tags": [
-    "bad-practice"
+    "bad-practice",
+    "type-dependent"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2871",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2933.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2933.json
@@ -13,7 +13,8 @@
     "constantCost": "2min"
   },
   "tags": [
-    "confusing"
+    "confusing",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2933",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2999.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2999.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "10min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-2999",
   "sqKey": "S2999",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3003.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3003.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3003",
   "sqKey": "S3003",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3402.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3402.json
@@ -13,7 +13,8 @@
     "constantCost": "15min"
   },
   "tags": [
-    "confusing"
+    "confusing",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-3402",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3403.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3403.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3403",
   "sqKey": "S3403",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3525.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3525.json
@@ -13,7 +13,8 @@
     "constantCost": "5min"
   },
   "tags": [
-    "es2015"
+    "es2015",
+    "type-dependent"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-3525",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3533.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3533.json
@@ -15,7 +15,8 @@
   "tags": [
     "convention",
     "es2015",
-    "obsolete"
+    "obsolete",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-3533",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3579.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3579.json
@@ -13,7 +13,8 @@
     "constantCost": "10min"
   },
   "tags": [
-    "bad-practice"
+    "bad-practice",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3579",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3696.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3696.json
@@ -14,7 +14,8 @@
   },
   "tags": [
     "error-handling",
-    "api-design"
+    "api-design",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3696",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3735.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3735.json
@@ -13,7 +13,8 @@
     "constantCost": "5min"
   },
   "tags": [
-    "confusing"
+    "confusing",
+    "type-dependent"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-3735",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3757.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3757.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "10min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3757",
   "sqKey": "S3757",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3758.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3758.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "10min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3758",
   "sqKey": "S3758",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3760.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3760.json
@@ -13,7 +13,8 @@
     "constantCost": "2min"
   },
   "tags": [
-    "confusing"
+    "confusing",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3760",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3776.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3776.json
@@ -21,7 +21,7 @@
   "ruleSpecification": "RSPEC-3776",
   "sqKey": "S3776",
   "scope": "Main",
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3782.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3782.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3782",
   "sqKey": "S3782",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3785.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3785.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-3785",
   "sqKey": "S3785",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3796.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3796.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Blocker",
   "ruleSpecification": "RSPEC-3796",
   "sqKey": "S3796",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3800.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3800.json
@@ -13,7 +13,8 @@
     "constantCost": "20min"
   },
   "tags": [
-    "confusing"
+    "confusing",
+    "type-dependent"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3800",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3981.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3981.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "2min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-3981",
   "sqKey": "S3981",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4043.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4043.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-4043",
   "sqKey": "S4043",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4123.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4123.json
@@ -13,7 +13,8 @@
     "constantCost": "1min"
   },
   "tags": [
-    "confusing"
+    "confusing",
+    "type-dependent"
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-4123",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4139.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4139.json
@@ -12,7 +12,9 @@
     "func": "Constant\/Issue",
     "constantCost": "5min"
   },
-  "tags": [],
+  "tags": [
+    "type-dependent"
+  ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-4139",
   "sqKey": "S4139",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4157.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4157.json
@@ -13,7 +13,8 @@
     "constantCost": "2min"
   },
   "tags": [
-    "clumsy"
+    "clumsy",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-4157",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4324.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4324.json
@@ -13,7 +13,8 @@
     "constantCost": "2min"
   },
   "tags": [
-    "proficiency"
+    "proficiency",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-4324",

diff --git a/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4325.json b/...avascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4325.json
@@ -13,7 +13,8 @@
     "constantCost": "1min"
   },
   "tags": [
-    "redundant"
+    "redundant",
+    "type-dependent"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-4325",