refactor: online sync plans code refactor & small features #114
Conversation
qamarq
changed the title
There was a problem hiding this comment.
Copilot reviewed 6 out of 18 changed files in this pull request and generated no suggestions.
Files not reviewed (12)
- frontend/package-lock.json: Language not supported
- frontend/package.json: Language not supported
- frontend/src/app/plans/edit/[id]/page.client.tsx: Evaluated as low risk
- frontend/src/app/plans/edit/[id]/page.tsx: Evaluated as low risk
- frontend/src/app/plans/page.client.tsx: Evaluated as low risk
- frontend/src/actions/plans.ts: Evaluated as low risk
- frontend/src/app/plans/page.tsx: Evaluated as low risk
- frontend/src/app/layout.tsx: Evaluated as low risk
- frontend/src/lib/usePlan.ts: Evaluated as low risk
- frontend/src/components/PlanDisplayLink.tsx: Evaluated as low risk
- frontend/src/app/plans/edit/[id]/_components/SyncedButton.tsx: Evaluated as low risk
- frontend/src/app/plans/edit/[id]/_components/OfflineAlert.tsx: Evaluated as low risk
| <CloudIcon className="size-4 text-emerald-500" /> | ||
| ) : !(onlineId ?? "") ? ( | ||
| <AlertTriangleIcon className="size-4 text-rose-500" /> | ||
| ) : syncing ? ( |
There was a problem hiding this comment.
Nie można tutaj jakoś ładniej tego zrobić? Bo te ternary w renderze trochę średnio wyglądają
| className="min-w-10" | ||
| onClick={() => { | ||
| if (!equalsDates) { | ||
| bounceAlert(); |
frontend/src/lib/usePlan.ts
Outdated
| import { useAtom } from "jotai"; | ||
|
|
||
| import { type ExtendedCourse, planFamily } from "@/atoms/planFamily"; | ||
|
|
||
| import type { Registration } from "./types"; | ||
|
|
||
| export interface PlanState { |
There was a problem hiding this comment.
Nie chcemy wszystkich interfejsów razem trzymać w types?
There was a problem hiding this comment.
chcemy, lint bartusia nie chce
There was a problem hiding this comment.
ale Marcinowi chodziło to żeby wrzucić to do folderu types 😭
wywailem env baseurl bo doslownie do niczego ona nie byla potrzebne, tylko robilismy z tego apps url wiec po prostu to dodalem do env, dzieki czemu moglem uzywac tego pliku tez po kliencie jak juz nie bylo eksportu serwerowego, do tego lepsze nazwy i mniej zmiennych w funkcjach w page.client
There was a problem hiding this comment.
nice, o wiele lepsze te abstrakcje, nadal niektóre if'ologie bym wydzielił do funkcji, ale jest dobrze
też te aktualizowanie bym zrobił automatycznie w tle, żeby user nic nie musiał klikać (a Tobie by to oszczędziło kodu na alerty), ale to pewnie poza scopem tej pr'ki
| } | ||
| }} | ||
| > | ||
| {plan.synced && isEqualsDates ? ( |
There was a problem hiding this comment.
nie poprawiłeś tego, nadal dublujesz logike i tutaj i tam na górze w useMemo
| * @param plan **plan** object from useAtom() | ||
| * @returns Objects: ```{ status: "NOT_LOGGED_IN" | "UNKNOWN", message: string }``` or ```{ status: "SUCCESS" }``` | ||
| */ | ||
| export const createOnlinePlan = async ( |
This pull request includes various updates and improvements to the frontend codebase, particularly involving the addition of a new tooltip component and the refactoring of plan-related types and functions. The most important changes include adding the
@radix-ui/react-tooltippackage, refactoring type imports, and enhancing the user interface with tooltips and offline alerts.Package Updates:
@radix-ui/react-tooltipversion1.1.4topackage.jsonandpackage-lock.json. [1] [2] [3]Type Refactoring:
frontend/src/actions/plans.tsto use a centralized types file.UI Enhancements:
TooltipProviderto the root layout infrontend/src/app/layout.tsxto enable tooltips across the application. [1] [2] [3]SyncedButtoncomponent to provide additional context to users. (frontend/src/app/plans/edit/[id]/_components/SyncedButton.tsxL10-R17, frontend/src/app/plans/edit/[id]/_components/SyncedButton.tsxR26-R59, frontend/src/app/plans/edit/[id]/_components/SyncedButton.tsxR77-R81)OfflineAlertcomponent to notify users when they are offline. (frontend/src/app/plans/edit/[id]/_components/OfflineAlert.tsxR1-R12)Code Organization:
CreateNewPlanPagetopage.client.tsxand updated imports accordingly. (frontend/src/app/plans/edit/[id]/page.client.tsxL4-R12, frontend/src/app/plans/edit/[id]/page.client.tsxR32-R41, frontend/src/app/plans/edit/[id]/page.tsxL5-R5)