-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/fb-posts-page - Issue #33 #38
Conversation
8ea7070
to
33de3fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- template.env.local: Language not supported
- src/app/news/components/post-attachments.tsx: Evaluated as low risk
- src/app/news/components/post.tsx: Evaluated as low risk
- src/app/news/components/share-button.tsx: Evaluated as low risk
Jak na razie można imo wdrożyć to co jest bo troche pododane, a UI się zaktualizuje jak Basia czy ktoś inny to przygotuje |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wygląda elegancko, głównie uiowe rzeczy wiec bardzo sie nie wczytywalam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- template.env.local: Language not supported
- src/app/news/components/post.tsx: Evaluated as low risk
- src/app/news/components/share-button.tsx: Evaluated as low risk
- src/app/news/page.tsx: Evaluated as low risk
Comments suppressed due to low confidence (5)
src/app/news/components/post-attachments.tsx:23
- Remove or uncomment the commented-out lines for width and height in the Image component.
// width={attachment.media.image.width}
src/app/news/components/post-attachments.tsx:19
- [nitpick] The alt attribute for the Image component could be more descriptive. Consider using a more specific description.
alt={"Facebook post image attachment"}
src/lib/facebook.ts:22
- [nitpick] The variable name 'getAccessTokenPromise' is not descriptive. It should be renamed to 'accessTokenPromise'.
let getAccessTokenPromise: null | Promise<string | null> = null;
src/lib/facebook.ts:35
- The error message 'No short-lived access token set for Facebook API' could be more descriptive to help with debugging.
console.error("No short-lived access token set for Facebook API");
src/lib/facebook.ts:78
- The console log statement 'console.log(token);' should be removed if it's not necessary for debugging.
console.log(token);
f49bc8a
to
393c265
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super robota! :3
* also renamed files to match kebab-case
+ error handling for share button component + only running the facebook access token extension promise once
1fd94d9
to
8f0c1f7
Compare
template.local.env
)/postsFb
na/news
/news