Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fb-posts-page - Issue #33 #38

Merged
merged 6 commits into from
Dec 19, 2024
Merged

feat/fb-posts-page - Issue #33 #38

merged 6 commits into from
Dec 19, 2024

Conversation

kguzek
Copy link
Member

@kguzek kguzek commented Dec 14, 2024

  • fixy związane z Facebook API (optymalizacja requestów, uzupełnienie template.local.env)
  • wyświetlanie dodatkówych załączników pod postami
  • obsługa błędów przy udostępnianiu linków
  • refactoryzacja /postsFb na /news
  • responsywność całej strony /news
  • naprawienie tytułów postów po tym jak @Rei-x zepsuł
  • wdrożyć UI od grafików

@kguzek kguzek force-pushed the feat/fb-posts-page branch from 8ea7070 to 33de3fe Compare December 14, 2024 20:39
@kguzek kguzek linked an issue Dec 14, 2024 that may be closed by this pull request
@kguzek kguzek marked this pull request as ready for review December 14, 2024 22:32
@Copilot Copilot bot review requested due to automatic review settings December 14, 2024 22:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • template.env.local: Language not supported
  • src/app/news/components/post-attachments.tsx: Evaluated as low risk
  • src/app/news/components/post.tsx: Evaluated as low risk
  • src/app/news/components/share-button.tsx: Evaluated as low risk
@kguzek
Copy link
Member Author

kguzek commented Dec 14, 2024

Jak na razie można imo wdrożyć to co jest bo troche pododane, a UI się zaktualizuje jak Basia czy ktoś inny to przygotuje

Octopus4344
Octopus4344 previously approved these changes Dec 14, 2024
Copy link
Collaborator

@Octopus4344 Octopus4344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wygląda elegancko, głównie uiowe rzeczy wiec bardzo sie nie wczytywalam

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • template.env.local: Language not supported
  • src/app/news/components/post.tsx: Evaluated as low risk
  • src/app/news/components/share-button.tsx: Evaluated as low risk
  • src/app/news/page.tsx: Evaluated as low risk
Comments suppressed due to low confidence (5)

src/app/news/components/post-attachments.tsx:23

  • Remove or uncomment the commented-out lines for width and height in the Image component.
// width={attachment.media.image.width}

src/app/news/components/post-attachments.tsx:19

  • [nitpick] The alt attribute for the Image component could be more descriptive. Consider using a more specific description.
alt={"Facebook post image attachment"}

src/lib/facebook.ts:22

  • [nitpick] The variable name 'getAccessTokenPromise' is not descriptive. It should be renamed to 'accessTokenPromise'.
let getAccessTokenPromise: null | Promise<string | null> = null;

src/lib/facebook.ts:35

  • The error message 'No short-lived access token set for Facebook API' could be more descriptive to help with debugging.
console.error("No short-lived access token set for Facebook API");

src/lib/facebook.ts:78

  • The console log statement 'console.log(token);' should be removed if it's not necessary for debugging.
console.log(token);
@kguzek kguzek requested a review from Octopus4344 December 15, 2024 12:50
@kguzek kguzek force-pushed the feat/fb-posts-page branch 2 times, most recently from f49bc8a to 393c265 Compare December 18, 2024 00:15
Octopus4344
Octopus4344 previously approved these changes Dec 18, 2024
Copy link
Collaborator

@Octopus4344 Octopus4344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super robota! :3

@kguzek kguzek enabled auto-merge (rebase) December 19, 2024 19:27
@kguzek kguzek requested a review from Octopus4344 December 19, 2024 19:30
@kguzek kguzek merged commit e219783 into main Dec 19, 2024
1 check passed
@kguzek kguzek deleted the feat/fb-posts-page branch December 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat/ posts view posts page
2 participants