Add planner advert #557
Add planner advert #557
Conversation
| @@ -35,7 +37,7 @@ class HomeView extends StatelessWidget { | |||
| child: ListView.separated( | |||
| itemBuilder: (context, index) => sections[index], | |||
| separatorBuilder: (context, index) => SizedBox( | |||
| height: index == 1 ? 0 : HomeViewConfig.paddingMedium, | |||
| height: index == 1 || index == 2 ? 0 : HomeViewConfig.paddingMedium, | |||
There was a problem hiding this comment.
did you check how this will behave when the advert is turned off?
There was a problem hiding this comment.
Yes I did, imo not bad (please see the pic below). If you like, I will reduce it a bit, but one question arise. Do you have an idea how to do it right? Currently I can't see other options that manually added spacers (besides making HomeScreen Consumer widget, imo wrong way).
There was a problem hiding this comment.
no better ideas. If you don't want any ifs in the separator, then u can give padding directly to children, just by wrapping them in Padding, but here this will look bad. Imo the current solution is ok
There was a problem hiding this comment.
also the padding seems fine
|
@mikolaj-jalocha planner -> planer 😭 |
technicalMessagewidget. Whole operation wasn't intrusive and easy to perform. I decided not to implement separate widget for that, new improvements seems useful afterall.