Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dressing rooms to digital guide #547

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Add dressing rooms to digital guide #547

merged 5 commits into from
Jan 23, 2025

Conversation

mikolaj-jalocha
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha commented Jan 23, 2025 •
edited
Loading

#541

  • 1:1 changes as with lodges (I also changed working hours to be displayed only when information's available)
  • I was thinking for a moment whether to create single UI that'd handle lodges and dressing rooms but finally decided just to copy and adjust existing solution. Imo digital guide structure is complicated, there's no point in complicating it even more, minor code repetition is not a sin in this scenario I believe 😆 But let me know WDYT

@mikolaj-jalocha mikolaj-jalocha added the enhancement New feature or request label Jan 23, 2025
@mikolaj-jalocha mikolaj-jalocha self-assigned this Jan 23, 2025
simon-the-shark
simon-the-shark approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :))

So little repetition is not a problem. It's actually considered a good production code, cause abstraction layers are not good when they don't bring us much value. So good decision here imo.

@simon-the-shark simon-the-shark linked an issue Jan 23, 2025 that may be closed by this pull request
/feat(digital-guide) add "szatnia" section #541
Closed
@simon-the-shark simon-the-shark merged commit d24eae7 into main Jan 23, 2025
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/digital-guide-dressing-rooms branch January 23, 2025 21:50
mmzek pushed a commit that referenced this pull request Jan 26, 2025
@mikolaj-jalocha @mmzek
feat(digital-guide): add dressing room section (#547)
f1d2ea6 
* feta(digital-guide): setup data layer

* feta(digital-guide): setup presentation layer

* feta(digital-guide): add docs

* chore(digital-guide): fix linter complaints

* feat(digital-guide): working hours displayed only when info's provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-the-shark simon-the-shark simon-the-shark approved these changes

@tomasz-trela tomasz-trela Awaiting requested review from tomasz-trela

Assignees

@mikolaj-jalocha mikolaj-jalocha

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging this pull request may close these issues.

/feat(digital-guide) add "szatnia" section
2 participants
@mikolaj-jalocha @simon-the-shark