Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(digital-guide): add support for levels #534

Merged
merged 6 commits into from
Jan 18, 2025
Merged

feat(digital-guide): add support for levels #534

merged 6 commits into from
Jan 18, 2025

Conversation

mikolaj-jalocha
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha commented Jan 17, 2025 •
edited
Loading

@mikolaj-jalocha mikolaj-jalocha added the enhancement New feature or request label Jan 17, 2025
@mikolaj-jalocha mikolaj-jalocha self-assigned this Jan 18, 2025
@mikolaj-jalocha mikolaj-jalocha changed the title feat(digital-guide): add support for levels - WIP 🛠️ feat(digital-guide): add support for levels Jan 18, 2025
@mikolaj-jalocha mikolaj-jalocha marked this pull request as ready for review January 18, 2025 14:19
simon-the-shark
simon-the-shark previously approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@simon-the-shark simon-the-shark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)). Not sure about the padding between the levels section though, at least on the ss it looks like a lot of empty space

lib/features/digital_guide_view/tabs/rooms/data/repository/rooms_repository.dart Outdated Show resolved Hide resolved
@mikolaj-jalocha
Copy link
Member Author

Quick fix. Unfortunately I can't test it right now with the same id as in PR's screen but should look good now. In case it is wrong, I will fix it all together in single commit with others small issues.

@simon-the-shark simon-the-shark merged commit d34401b into main Jan 18, 2025
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/levels-in-digital-guides-rooms branch January 18, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-the-shark simon-the-shark simon-the-shark left review comments

@tomasz-trela tomasz-trela Awaiting requested review from tomasz-trela

Assignees

@mikolaj-jalocha mikolaj-jalocha

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging this pull request may close these issues.
2 participants
@mikolaj-jalocha @simon-the-shark