Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/connect digital guide #533

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Feat/connect digital guide #533

merged 3 commits into from
Jan 17, 2025

Conversation

simon-the-shark
Copy link
Member

  1. connect digital guide to our building tiles with "i" icon
    • I allow to set manually id on the backend and the option if this is normal building, "other place" (different endpoint) or web url, cause why can't we set deeplink to sks menu or just url somewhere here too
  2. I use OUR photos in the digital guide detail too, cause previously this could be confusing that the photo was different on the list and in the detail

I only added few for testing for now, @odominiak will insert rest soon

Zrzut ekranu 2025-01-17 o 00 24 28
Zrzut ekranu 2025-01-17 o 00 29 54
Zrzut ekranu 2025-01-17 o 00 30 09

@simon-the-shark simon-the-shark added the enhancement New feature or request label Jan 16, 2025
@simon-the-shark simon-the-shark self-assigned this Jan 16, 2025
@simon-the-shark simon-the-shark force-pushed the feat/connect-digital-guide branch from c9b4f55 to f0180c3 Compare January 16, 2025 23:49
mikolaj-jalocha
mikolaj-jalocha approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

it'd be nice to add some sort of restaurant symbol to SKS's tile 😋 or deep link to parking if it's close to given building.

@simon-the-shark simon-the-shark merged commit 8075640 into main Jan 17, 2025
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/connect-digital-guide branch January 17, 2025 20:34
@simon-the-shark simon-the-shark linked an issue Jan 17, 2025 that may be closed by this pull request
feat/ (digital-guide): integrate digital guide's screens with other parts of the app #529
Closed
mmzek pushed a commit that referenced this pull request Jan 18, 2025
@simon-the-shark @mmzek
feat(digital-guide): connect building list to directus (#533)
92cdc88 
* feat(digital-guide): connect building list to directus

* fix(digital-guide): use our photos

* chore(digital-guide): remove temp action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikolaj-jalocha mikolaj-jalocha mikolaj-jalocha approved these changes

@tomasz-trela tomasz-trela Awaiting requested review from tomasz-trela

Assignees

@simon-the-shark simon-the-shark

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging this pull request may close these issues.

feat/ (digital-guide): integrate digital guide's screens with other parts of the app
2 participants
@simon-the-shark @mikolaj-jalocha