Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/digital guide rooms #531

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Feat/digital guide rooms #531

merged 8 commits into from
Jan 16, 2025

Conversation

mikolaj-jalocha
Copy link
Member

#495

  • please query the room's endpoint and check if enough information are provided (I omitted certain fields).

Simulator Screenshot - iPhone 16 - 2025-01-15 at 16 10 40 Simulator Screenshot - iPhone 16 - 2025-01-15 at 16 10 13 Simulator Screenshot - iPhone 16 - 2025-01-15 at 16 10 20

@mikolaj-jalocha mikolaj-jalocha added the enhancement New feature or request label Jan 15, 2025
@mikolaj-jalocha mikolaj-jalocha self-assigned this Jan 15, 2025
@tomasz-trela
Copy link
Member

tomasz-trela commented Jan 16, 2025 •
edited
Loading

Zrzut ekranu 2025-01-16 o 13 40 09
I would add a little bit of padding between these widgets (button and text)

tomasz-trela
tomasz-trela reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@tomasz-trela tomasz-trela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality of code is great. LGTM!

simon-the-shark
simon-the-shark reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@simon-the-shark simon-the-shark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice job, only 2 small improvements propositions

lib/features/digital_guide_view/tabs/rooms/data/models/digital_guide_room.dart Show resolved Hide resolved
lib/features/digital_guide_view/tabs/rooms/presentation/digital_guide_room_detail_view.dart Outdated Show resolved Hide resolved
@simon-the-shark simon-the-shark linked an issue Jan 16, 2025 that may be closed by this pull request
/feat(digital-guide): add "pomieszczenia" section along with content #495
Closed
@simon-the-shark simon-the-shark merged commit c9500a2 into main Jan 16, 2025
2 checks passed
@simon-the-shark simon-the-shark deleted the feat/digital-guide-rooms branch January 16, 2025 15:07
mmzek pushed a commit that referenced this pull request Jan 18, 2025
@mikolaj-jalocha @mmzek
feat(digital-guide): add rooms content (#531)
c96dbf2 
* feat(digital-guide): add data layer for rooms section

* feat(digital-guide): add presentation layer

* feat(digital-guide): navigation

* feat(digital-guide): localization

* feat(digital-guide): docs

* feat(digital-guide): apply pr's fixes

* feat(digital-guide): final touch

* feat(digital-guide): final touch v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasz-trela tomasz-trela tomasz-trela left review comments

@simon-the-shark simon-the-shark simon-the-shark approved these changes

Assignees

@mikolaj-jalocha mikolaj-jalocha

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0 - Mr. Shark, We Have to Cook
Development

Successfully merging this pull request may close these issues.

/feat(digital-guide): add "pomieszczenia" section along with content
3 participants
@mikolaj-jalocha @tomasz-trela @simon-the-shark