Round images in adapted toilets #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24bartixx
requested review from
mikolaj-jalocha,
simon-the-shark and
tomasz-trela
and removed request for
mikolaj-jalocha and
simon-the-shark
lib/features/digital_guide_view/presentation/digital_guide_view.dart
Outdated
Show resolved
Hide resolved
|
@24bartixx tbh I don't know why the zoomable one is bad. Something to discuss in a wider group on a meeting. When it comes to photo row - sure, I have similar conclusions, it can stay as it is for now in this view, imo it looks pretty ok |
simon-the-shark
force-pushed
the
refactor/adapted-toilets-photo-row
branch
from
3ed3aad to
e5acc4d
Compare
simon-the-shark
approved these changes
Jan 13, 2025
mmzek
pushed a commit
that referenced
this pull request
Jan 18, 2025
* refactor: round images in adapted toilet and disable zoomable in digital guide view * fix(digital-guide): remove zoomable = false --------- Co-authored-by: Szymon Kowaliński <szymon@kowalinski.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round images in adapted toilets
zoomable = false in digital guide view - prevents this
Additional info
I tried to use DigitalGuidePhotoRow in adapted toilets and I even fixed row stretching in this widget but it looked awkward because of the images ratio.