Feat/open buildings from contact #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 9, 2024
simon-the-shark
force-pushed
the
feat/open-buildings-from-contact
branch
from
f6fe9da to
ce48c25
Compare
mikolaj-jalocha
approved these changes
Aug 9, 2024
| return GestureDetector( | ||
| onTap: () async { | ||
| await LaunchUrlUtil.launch(url); | ||
| await ref.launch(url); |
There was a problem hiding this comment.
Can we use here unawaited?
There was a problem hiding this comment.
Sure, but also there's nothing after it, so
onTap: () async => ref.launch(url),should have similar effect I believe
| import "../utils/where_non_null_iterable.dart"; | ||
|
|
||
| extension LaunchUrlUtilX on WidgetRef? { | ||
| Future<bool> launch(String uriStr) async { |
There was a problem hiding this comment.
I like the change here. Universal in all places rn.
simon-the-shark
force-pushed
the
feat/open-buildings-from-contact
branch
from
ce48c25 to
d2842fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been fixing some issues that occured during filling the info in the backend and done the opening links as well (haven't seen your assignemnet @mikolaj-jalocha ) Upsik
plactopl.to be consistent with buildings3.24.0