Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ normalize markers size #130

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Fix/ normalize markers size #130

merged 2 commits into from
Aug 3, 2024

Conversation

simon-the-shark
Copy link
Member

@simon-the-shark simon-the-shark commented Aug 3, 2024 •
edited
Loading

Fix of #95

TODO: Test on multiple devices

How it looks on my device now

image
image

Update

Reversed slide from bottom transitions in detail view to default ones

@simon-the-shark simon-the-shark self-assigned this Aug 3, 2024
@simon-the-shark simon-the-shark changed the title fix(map): normalize markers size Fix/ normalize markers size Aug 3, 2024
@simon-the-shark simon-the-shark linked an issue Aug 3, 2024 that may be closed by this pull request
[Mobile - 49] Release build: small map markers (not always) #95
Closed
@simon-the-shark simon-the-shark mentioned this pull request Aug 3, 2024
Merged
mikolaj-jalocha
mikolaj-jalocha approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did test on Android Device emulator (Pixel 7).

One thing'd consider to change is the active marker's size. Imo slightly too large. But that's just my suggestion

@simon-the-shark
Copy link
Member Author

I've tried to imitate 1:1 from figma, but yeah we can make the active one a bit smaller.

@simon-the-shark
Copy link
Member Author

I've set it to 80% of the size it was

@simon-the-shark simon-the-shark merged commit 6756719 into fix/home-jumping-scroll Aug 3, 2024
2 checks passed
@simon-the-shark simon-the-shark deleted the fix/map-markers branch August 3, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikolaj-jalocha mikolaj-jalocha mikolaj-jalocha approved these changes

Assignees

@simon-the-shark simon-the-shark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mobile - 49] Release build: small map markers (not always)
2 participants
@simon-the-shark @mikolaj-jalocha