Fix/ eliminate jumping scroll in home view #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-the-shark
force-pushed
the
fix/home-jumping-scroll
branch
from
03ac922 to
cfbd40c
Compare
simon-the-shark
changed the title
mikolaj-jalocha
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
WDYT about changing loading widget to contain slightly larger body (the gray area)? Just to fill the free space. Even with plain gray block or with more lines? Just a proposition of mine. I'm not sure if that'd fix the problem?
Same as you, I feel very uneasy about handling the reference down...
|
Very good idea, bigger body might improve its look a bit. I'll try something in a second. But also in most scenarios this won't be visible for too long if even visible at all |
|
|
simon-the-shark
force-pushed
the
fix/home-jumping-scroll
branch
from
6756719 to
0ea82e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't be scared with stacked PRs :) this one is very simple. Just make reviews of every one of them and I'll merge them in the end together.
FIx of #104
ListView.builderit was rebuilding just in that specific moment and trigger the rebuild and weird scroll mechanics.Previews
Issue (before changes)
ezgif-4-b283fa0278.mov
Results
Nagranie.z.ekranu.2024-08-3.o.15.21.39.mov
Changes.
News section.
this was main problem.
Loaded state (no changes).
Loading state BEFORE.
Loading state AFTER.
Alternative
Alternative solution is to preserve
newsRepositoryprovider in the memory, either withkeepAlive: true(don't like the idea) or just subscribing to it in the lower section of the home view (feel very hacky). But if you think current loading looks significatly worse, we can solve this this way too.