Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix tests after v1 release #3306

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Dec 19, 2024

Fix tests after V1:

  • TestAcc_Functions
  • TestAcc_Procedures
  • TestAcc_ExternalFunction_complete
  • TestAcc_GrantOwnership_OnObject_ProcedureWithArguments_ToAccountRole
  • TestAcc_GrantOwnership_OnObject_ProcedureWithoutArguments_ToDatabaseRole
  • extended authenticator unit test
  • Parameters tests were not altered but the environment was adjusted (to verify if they will still fail)

Additionally:

  • added 3 missing preview features (2 needed for tests and 1 just missing for completion)

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review December 19, 2024 16:01
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls also adjust the migration guide

Copy link

Integration tests failure for 5600673da10e14769b9f7cb875f3693638411611

@sfc-gh-asawicki sfc-gh-asawicki merged commit 0d5b45a into dev Dec 19, 2024
10 of 11 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-tests-after-v1-release branch December 19, 2024 17:04
sfc-gh-asawicki added a commit that referenced this pull request Dec 20, 2024
Fix tests after V1:
- TestAcc_Functions
- TestAcc_Procedures
- TestAcc_ExternalFunction_complete
- TestAcc_GrantOwnership_OnObject_ProcedureWithArguments_ToAccountRole
-
TestAcc_GrantOwnership_OnObject_ProcedureWithoutArguments_ToDatabaseRole
- extended authenticator unit test
- Parameters tests were not altered but the environment was adjusted (to
verify if they will still fail)

Additionally:
- added 3 missing preview features (2 needed for tests and 1 just
missing for completion)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants