feat: Unsafe execute v1 readiness #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 58861be362210f07ea6cb02051455064edbec50a |
|
Integration tests failure for 74827d5a18f556490c0014a28e51159264f28bfc |
|
Integration tests failure for 4efc5b6d5c063ed862085c8a92e45ac21e0dd6a7 |
sfc-gh-asawicki
requested changes
Dec 11, 2024
| @@ -108,6 +108,7 @@ body: | |||
| - resource:database_role | |||
| - resource:dynamic_table | |||
| - resource:email_notification_integration | |||
| - resource:execute | |||
There was a problem hiding this comment.
I totally forgot about adding new resources here. Can I just add them or do I need to add the matching labels first? (e.g. for new functions and procedures)
There was a problem hiding this comment.
Hmm, that is a good question, and I couldn't find an answer for it. Maybe we can see after merging this one because I haven't added labels in the repo yet.
There was a problem hiding this comment.
Note: we have SNOW-1831333 for this.
|
Integration tests failure for 38631ba531fcadf69b63c4ceac7726b2d8f1db93 |
sfc-gh-jmichalak
previously approved these changes
Dec 12, 2024
| @@ -108,6 +108,7 @@ body: | |||
| - resource:database_role | |||
| - resource:dynamic_table | |||
| - resource:email_notification_integration | |||
| - resource:execute | |||
There was a problem hiding this comment.
Note: we have SNOW-1831333 for this.
|
Integration tests failure for 558725a15c8dab536ac6e56e08ee79f36c2d7fa1 |
sfc-gh-asawicki
previously approved these changes
Dec 12, 2024
# Conflicts: # MIGRATION_GUIDE.md
sfc-gh-jcieslak
dismissed stale reviews from sfc-gh-asawicki and sfc-gh-jmichalak
via
246a529
|
Integration tests cancelled for 246a5290680a5a415f0472b5d6bae873ce44fd76 |
sfc-gh-jmichalak
previously approved these changes
Dec 12, 2024
# Conflicts: # MIGRATION_GUIDE.md
sfc-gh-jmichalak
approved these changes
Dec 12, 2024
sfc-gh-asawicki
approved these changes
Dec 12, 2024
|
Integration tests cancelled for 0e681aaa63b2fb337e61ba9de0202da53db1f079 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.100.0](v0.99.0...v0.100.0) (2024-12-12) ### 🎉 **What's new:** * Account v1 readiness ([#3236](#3236)) ([5df33a8](5df33a8)) * Account v1 readiness generated files ([#3242](#3242)) ([3df59dd](3df59dd)) * Account v1 readiness resource ([#3252](#3252)) ([8f5698d](8f5698d)) * Add a new account roles data source ([#3257](#3257)) ([b3d6b9e](b3d6b9e)) * Add account data source ([#3261](#3261)) ([6087fc9](6087fc9)) * Add all other functions and procedures implementations ([#3275](#3275)) ([7a6f68d](7a6f68d)) * Basic functions implementation ([#3269](#3269)) ([6d4a103](6d4a103)) * Basic procedures implementation ([#3271](#3271)) ([933335f](933335f)) * Docs, test, and missing parameter ([#3280](#3280)) ([10517f3](10517f3)) * Functions and procedures schemas and generated sources ([#3262](#3262)) ([9b70f87](9b70f87)) * Functions sdk update ([#3254](#3254)) ([fc1eace](fc1eace)) * Handle missing fields in function and procedure ([#3273](#3273)) ([53e7a0a](53e7a0a)) * Procedures schemas and generated sources ([#3263](#3263)) ([211ad46](211ad46)) * Procedures sdk update ([#3255](#3255)) ([682606a](682606a)) * Rework account parameter resource ([#3264](#3264)) ([15aa9c2](15aa9c2)) * Rework data types ([#3244](#3244)) ([05ada91](05ada91)) * support table data type ([#3274](#3274)) ([13401d5](13401d5)) * Tag association v1 readiness ([#3210](#3210)) ([04f6d54](04f6d54)) * Test imports and small fixes ([#3276](#3276)) ([a712195](a712195)) * Unsafe execute v1 readiness ([#3266](#3266)) ([c4f1e8f](c4f1e8f)) * Use new data types in sql builder for functions and procedures ([#3247](#3247)) ([69f677a](69f677a)) ### 🔧 **Misc** * Add ShowByID filtering generation ([#3227](#3227)) ([548ec42](548ec42)) * Adress small task-related todos ([#3243](#3243)) ([40de9ae](40de9ae)) * Apply masking ([#3234](#3234)) ([c209a8a](c209a8a)) * fix missing references in toOpts and changes with newlines ([#3240](#3240)) ([246547f](246547f)) * function tests ([#3279](#3279)) ([5af6efb](5af6efb)) * Improve config builders ([#3207](#3207)) ([425787c](425787c)) * Revert to proper env ([#3238](#3238)) ([5d4ed3b](5d4ed3b)) * Use service user for ci ([#3228](#3228)) ([2fb50d7](2fb50d7)) ### 🐛 **Bug fixes:** * Make blocked_roles_field optional in OAuth security integrations ([#3267](#3267)) ([7197b57](7197b57)) * Minor fixes ([#3231](#3231)) ([1863bf6](1863bf6)) * Minor fixes 2 ([#3230](#3230)) ([73b7e74](73b7e74)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes