feat: identifier validation #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jcieslak
force-pushed
the
identifier-validation
branch
from
c8d1163 to
eb49315
Compare
|
Integration tests failure for c8d11638c340c16034ec4a8013c886ded420cf69 |
|
Integration tests failure for eb49315ed5fe60766f1e250ce869b8b6327ae594 |
|
Integration tests failure for 0afa2918d7e35bf43c896c05d520512d7926c056 |
sfc-gh-asawicki
requested changes
Dec 14, 2023
|
Integration tests failure for 0aafa88f64a6ee5c5c7a19346adb49df4d9cc029 |
|
Integration tests success for 2d856b387ba4187551dd9fa2f666fae132b9da94 |
|
Integration tests failure for ad761c82cd5e6232553489dea42ee3c20cb8f15c |
|
Integration tests failure for ac28b62b8ad39a526ac376a61f7e84fff1a24bd8 |
sfc-gh-asawicki
approved these changes
Dec 15, 2023
|
Integration tests failure for f2701f87c4815f436df46c8ceac7804c42bf858a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a function that validates identifiers and prints readable error messages that sometimes may be able to help resolve the common issue of specifying identifiers incorrectly (especially in grant resources).
The validator will be used in the follow-up pull requests.
Test Plan