Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing parameters #2250

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: Add missing parameters #2250

merged 2 commits into from
Dec 11, 2023

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Dec 11, 2023 •
edited
Loading

Added parameters that allow to work with ICEBERG TABLES and EXTERNAL VOLUMES
Fix for #2248

@github-actions GitHub Actions
Copy link

Integration tests failure for 84ebf2cfb8d28b7d8fc2f7636d6bb94f08378711

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the fix-object-type-plural-in-grant_privileges_to_role branch from 84ebf2c to e7cbff9 Compare December 11, 2023 12:27
@github-actions GitHub Actions
Copy link

Integration tests failure for e7cbff918c0e90d80f2400e9b491c5edbde015ca

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the fix-object-type-plural-in-grant_privileges_to_role branch from e7cbff9 to f2862ad Compare December 11, 2023 13:11
@github-actions GitHub Actions
Copy link

Integration tests failure for f2862ad765b3bd24240d1b27b540e61c5609fc4c

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the fix-object-type-plural-in-grant_privileges_to_role branch from f2862ad to 7ef5aa2 Compare December 11, 2023 13:38
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 11, 2023 13:53
sfc-gh-asawicki
sfc-gh-asawicki requested changes Dec 11, 2023
View reviewed changes
pkg/resources/grant_privileges_to_role.go Show resolved Hide resolved
pkg/resources/grant_privileges_to_role.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_role.go Outdated Show resolved Hide resolved
pkg/resources/grant_privileges_to_role_acceptance_test.go Outdated Show resolved Hide resolved
pkg/sdk/grants_test.go Show resolved Hide resolved
pkg/sdk/privileges.go Show resolved Hide resolved
pkg/sdk/privileges.go Show resolved Hide resolved
@sfc-gh-jcieslak sfc-gh-jcieslak changed the title Add missing parameters fix: Add missing parameters Dec 11, 2023
@github-actions GitHub Actions
Copy link

Integration tests failure for 7ef5aa2a5405d518cc672c1bb220afc9b096850a

@github-actions GitHub Actions
Copy link

Integration tests success for 1a1f5492d3bd4be1ec3074aa2d0e61f5e08cf9b5

@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 11, 2023 14:38
@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 4f4c4a4 into main Dec 11, 2023
7 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the fix-object-type-plural-in-grant_privileges_to_role branch December 11, 2023 15:18
@snowflake-release-please snowflake-release-please bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-asawicki