Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use external tables from SDK #2228

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat: Use external tables from SDK #2228

merged 6 commits into from
Dec 12, 2023

Conversation

sfc-gh-jcieslak
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak commented Dec 1, 2023 •
edited
Loading

Change underlying implementation for external tables to use our SDK. (+ a little simplification and bug fix of schema tags).
A fix for #1564 will be applied in the next pr.

Test Plan

  • acceptance tests (already existing ones)
  • unit tests
  • integration test

References

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch from 3e74244 to bb1f160 Compare December 1, 2023 09:26
@sfc-gh-jcieslak sfc-gh-jcieslak changed the title Use external tables from SDK feat: Use external tables from SDK Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests failure for 3e742446f73b980d99591a747cdf24aae5ff751c

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests failure for bb1f16033c3f16e6d49c1a6dfd954a111f7288d3

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch from bb1f160 to c595eb1 Compare December 1, 2023 10:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests failure for c595eb16e887126bb88f93e7e5ddd617da979de9

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch 2 times, most recently from 3d0495c to 18ca30e Compare December 1, 2023 11:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests failure for 3d0495c3febbe67c9954c2102c3bc3666d07dcea

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch 2 times, most recently from 1d40d4d to 82716a1 Compare December 1, 2023 11:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests failure for 18ca30e12552c2c44c1d4d203b5ef7fceb053994

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests failure for 82716a1599a1823e9f657ae1d547b818ee1530bb

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Integration tests success for 1d40d4d0ea9dc57e4b8a2b4252e4168d57d02deb

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch from 82716a1 to 5b8b289 Compare December 4, 2023 07:37
@sfc-gh-jcieslak sfc-gh-jcieslak self-assigned this Dec 4, 2023
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch from 5b8b289 to a02968e Compare December 4, 2023 07:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Integration tests failure for 5b8b289230db7150382cbdc584354b85e0c8fd4e

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

Integration tests failure for a02968e78b0b60e7ac0bb3dc9f3c452b38330199

sfc-gh-asawicki
sfc-gh-asawicki requested changes Dec 4, 2023
View reviewed changes
pkg/resources/external_table.go Show resolved Hide resolved
pkg/resources/external_table.go Show resolved Hide resolved
pkg/resources/helpers.go Show resolved Hide resolved
pkg/resources/helpers.go Outdated Show resolved Hide resolved
pkg/sdk/external_tables.go Outdated Show resolved Hide resolved
@sfc-gh-asawicki sfc-gh-asawicki self-requested a review December 11, 2023 14:45
@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch 3 times, most recently from 27882f7 to 1214c17 Compare December 11, 2023 14:59
@github-actions GitHub Actions
Copy link

Integration tests failure for 5624a5b371c87e23e51b28e27693c5683349d83c

@github-actions GitHub Actions
Copy link

Integration tests failure for 27882f74faf721cc2b4c77ac790e68f5235e606f

@github-actions GitHub Actions
Copy link

Integration tests failure for 1214c17455490115664fd6597d5af48886bb0b6c

@github-actions GitHub Actions
Copy link

Integration tests failure for 1214c17455490115664fd6597d5af48886bb0b6c

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch from 0dc539e to 21b2099 Compare December 12, 2023 10:31
@github-actions GitHub Actions
Copy link

Integration tests cancelled for 0dc539e9dcd36872db6727956dc0c3034cb5ea9e

@sfc-gh-jcieslak sfc-gh-jcieslak force-pushed the use-external-table-from-sdk branch from 21b2099 to 10ebec8 Compare December 12, 2023 10:37
@github-actions GitHub Actions
Copy link

Integration tests failure for 21b2099a60cec4d020e856a2982fda4f12968a13

@github-actions GitHub Actions
Copy link

Integration tests failure for 10ebec829c817f9b1aabb04a4aa581349a11f14c

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 6941023 into main Dec 12, 2023
6 of 8 checks passed
@sfc-gh-jcieslak sfc-gh-jcieslak deleted the use-external-table-from-sdk branch December 12, 2023 11:45
@snowflake-release-please snowflake-release-please bot mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

@sfc-gh-swinkler sfc-gh-swinkler Awaiting requested review from sfc-gh-swinkler

Assignees

@sfc-gh-jcieslak sfc-gh-jcieslak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jcieslak @sfc-gh-asawicki