chore: Export QueryStruct #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests success for a1c43eea7418255913a1ab06362b0f6b625ead2c |
sfc-gh-jcieslak
force-pushed
the
export-query-builder
branch
from
a1c43ee to
2c7704e
Compare
|
Integration tests failure for 2c7704e840ba2ecfffbf9218002b5e21a083f987 |
1 similar comment
|
Integration tests failure for 2c7704e840ba2ecfffbf9218002b5e21a083f987 |
|
Integration tests success for 2c7704e840ba2ecfffbf9218002b5e21a083f987 |
sfc-gh-jcieslak
force-pushed
the
export-query-builder
branch
from
2c7704e to
118571e
Compare
|
Integration tests success for 118571e26d1cfe7d5d9e63c785dce3db5cd0fdd0 |
sfc-gh-asawicki
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains
Other name proposal could be to name the type QueryStructBuilder (and other struct builders too) and leave QueryStruct constructor name.
The change enables to create helper functions in definitions file, that are specific to given definition and shouldn't be put into generator common package.