Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add comments on columns defined in views #3000

Closed
1 task
SteveGad12345 opened this issue Aug 15, 2024 · 3 comments
Closed
1 task

[Feature]: Add comments on columns defined in views #3000

SteveGad12345 opened this issue Aug 15, 2024 · 3 comments
Assignees
@sfc-gh-jmichalak
Labels
feature-request Used to mark issues with provider's missing functionalities resource:view Issue connected to the snowflake_view resource

Comments

@SteveGad12345
Copy link

Use Cases or Problem Statement

Hi,

   We would like to add comments on columns defined in views. However, snowflake_view does not support it. Is it possible to add it ?

Category

category:resource

Object type(s)

resource:view

Proposal

Add a collection of column definitions which contain the name and the comment (similar to table definition).

How much impact is this issue causing?

High

Additional Information

If you have a viable workaround to suggest, it would be great.

Would you like to implement a fix?

  • Yeah, I'll take it 😎
@SteveGad12345 SteveGad12345 added the feature-request Used to mark issues with provider's missing functionalities label Aug 15, 2024
@sfc-gh-jmichalak
Copy link
Collaborator

sfc-gh-jmichalak commented Aug 16, 2024 •
edited
Loading

Hi @SteveGad12345 👋 , this resource is being reworked right now. We'll add this field 👍

@sfc-gh-jmichalak sfc-gh-jmichalak added the resource:view Issue connected to the snowflake_view resource label Aug 16, 2024
@sfc-gh-jmichalak sfc-gh-jmichalak changed the title [Feature]: [Feature]: Add comments on columns defined in views Aug 16, 2024
@sfc-gh-jcieslak
Copy link
Collaborator

Hey @SteveGad12345 👋
Yesterday, we released a new provider version (v0.95.0) that allows to specify comments on columns. Please upgrade using the migration guide and let us know if that's what you requested. Thank You :)

@sfc-gh-jmichalak
Copy link
Collaborator

Closing the issue due to inactivity.

@sfc-gh-jmichalak sfc-gh-jmichalak self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-jmichalak sfc-gh-jmichalak

Labels
feature-request Used to mark issues with provider's missing functionalities resource:view Issue connected to the snowflake_view resource
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfc-gh-jcieslak @sfc-gh-jmichalak @SteveGad12345