Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated configuration parameters from procedure resource #2291

Closed
LukLight opened this issue Dec 20, 2023 · 2 comments
Closed

Remove deprecated configuration parameters from procedure resource #2291

LukLight opened this issue Dec 20, 2023 · 2 comments
Labels
feature-request Used to mark issues with provider's missing functionalities

Comments

@LukLight
Copy link

Terraform CLI and Provider Versions

Terraform CLI: 1.0.9
Snowflake-Labs/snowflake Version: 0.47.0 -> 0.80.0

Use Cases or Problem Statement

According to the official Snowflake documentation using the optional parameter “VOLATILE/IMMUTABLE” is deprecated in all languages.
https://docs.snowflake.com/en/sql-reference/sql/create-procedure#optional-parameters
Currently, this does not result in any major errors when creating/updating a stored procedure via terraform, but it might will in the future.

Proposal

Get rid of optional parameter “return_behavior”:
https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/main/pkg/resources/procedure.go

How much impact is this issue causing?

Low

Additional Information

No response

@LukLight LukLight added the feature-request Used to mark issues with provider's missing functionalities label Dec 20, 2023
@sfc-gh-asawicki
Copy link
Collaborator

Hey @LukLight. Thanks for creating the issue.

We did not include these deprecated parameters in the SDK. We will remove it during migrating the resource to use the SDK implementation instead of the old one.

@LukLight
Copy link
Author

LukLight commented Feb 9, 2024

Sorry for the late answer @sfc-gh-asawicki !
I'll close the request as it is included in the Pull Request.

@LukLight LukLight closed this as completed Feb 9, 2024
sfc-gh-asawicki pushed a commit that referenced this issue Feb 13, 2024
updates procedure resource and data source to use SDK
fixes: 

#2381

#2291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Used to mark issues with provider's missing functionalities
Projects
None yet
Development

No branches or pull requests

2 participants