Fix minor stuff

pkg/sdk/external_tables_dto.go

@@ -81,6 +81,9 @@ func (v *ColumnInlineConstraintRequest) toOpts() *ColumnInlineConstraint {
 }
 
 func (v *InlineForeignKeyRequest) toOpts() *InlineForeignKey {
+	if v == nil {
+		return nil
+	}
 	return &InlineForeignKey{
 		TableName:  v.TableName,
 		ColumnName: v.ColumnName,

pkg/sdk/parameters.go

@@ -266,12 +266,12 @@ func (parameters *parameters) SetObjectParameterOnAccount(ctx context.Context, p
 }
 
 type setParameterOnObject struct {
-	alter            bool             `ddl:"static" sql:"ALTER"` //lint:ignore U1000 This is used in the ddl tag
+	alter            bool             `ddl:"static" sql:"ALTER"`
 	objectType       ObjectType       `ddl:"keyword"`
 	objectIdentifier ObjectIdentifier `ddl:"identifier"`
-	set              bool             `ddl:"static" sql:"SET"` //lint:ignore U1000 This is used in the ddl tag
+	set              bool             `ddl:"static" sql:"SET"`
 	parameterKey     ObjectParameter  `ddl:"keyword"`
-	equals           bool             `ddl:"static" sql:"="` //lint:ignore U1000 This is used in the ddl tag
+	equals           bool             `ddl:"static" sql:"="`
 	parameterValue   string           `ddl:"keyword"`
 }
 
@@ -829,8 +829,8 @@ type UserParametersUnset struct {
 
 // ShowParametersOptions is based on https://docs.snowflake.com/en/sql-reference/sql/show-parameters.
 type ShowParametersOptions struct {
-	show       bool          `ddl:"static" sql:"SHOW"`       //lint:ignore U1000 This is used in the ddl tag
-	parameters bool          `ddl:"static" sql:"PARAMETERS"` //lint:ignore U1000 This is used in the ddl tag
+	show       bool          `ddl:"static" sql:"SHOW"`
+	parameters bool          `ddl:"static" sql:"PARAMETERS"`
 	Like       *Like         `ddl:"keyword" sql:"LIKE"`
 	In         *ParametersIn `ddl:"keyword" sql:"IN"`
 }

pkg/sdk/table_dto.go

@@ -103,6 +103,7 @@ type ColumnIdentityRequest struct {
 	Start     int // required
 	Increment int // required
 }
+
 type ColumnMaskingPolicyRequest struct {
 	with  *bool
 	name  SchemaObjectIdentifier // required
@@ -326,6 +327,7 @@ type TableClusteringActionRequest struct {
 	ChangeReclusterState *ReclusterState
 	DropClusteringKey    *bool
 }
+
 type TableReclusterActionRequest struct {
 	MaxSize   *int
 	Condition *string
@@ -363,6 +365,7 @@ type TableColumnAddInlineConstraintRequest struct {
 	Type       ColumnConstraintType
 	ForeignKey *ColumnAddForeignKey
 }
+
 type ColumnAddForeignKeyRequest struct {
 	TableName  string
 	ColumnName string
@@ -385,15 +388,18 @@ type TableColumnAlterActionRequest struct {
 	Comment           *string
 	UnsetComment      *bool
 }
+
 type TableColumnAlterSetMaskingPolicyActionRequest struct {
 	ColumnName        string                 // required
 	MaskingPolicyName SchemaObjectIdentifier // required
 	Using             []string               // required
 	Force             *bool
 }
+
 type TableColumnAlterUnsetMaskingPolicyActionRequest struct {
 	ColumnName string // required
 }
+
 type TableColumnAlterSetTagsActionRequest struct {
 	ColumnName string           // required
 	Tags       []TagAssociation // required
@@ -408,16 +414,19 @@ type TableColumnNotNullConstraintRequest struct {
 	Set  *bool
 	Drop *bool
 }
+
 type TableConstraintActionRequest struct {
 	Add    *OutOfLineConstraintRequest
 	Rename *TableConstraintRenameActionRequest
 	Alter  *TableConstraintAlterActionRequest
 	Drop   *TableConstraintDropActionRequest
 }
+
 type TableConstraintRenameActionRequest struct {
 	OldName string
 	NewName string
 }
+
 type TableConstraintAlterActionRequest struct {
 	// One of
 	ConstraintName *string
@@ -434,6 +443,7 @@ type TableConstraintAlterActionRequest struct {
 	Rely        *bool
 	NoRely      *bool
 }
+
 type TableConstraintDropActionRequest struct {
 	// One of
 	ConstraintName *string
@@ -477,6 +487,7 @@ type TableExternalTableColumnAddActionRequest struct {
 	Type       DataType
 	Expression []string
 }
+
 type TableExternalTableColumnRenameActionRequest struct {
 	OldName string
 	NewName string
@@ -485,6 +496,7 @@ type TableExternalTableColumnRenameActionRequest struct {
 type TableExternalTableColumnDropActionRequest struct {
 	Columns []string
 }
+
 type ShowTableByIdRequest struct {
 	Terse      *bool
 	History    *bool
@@ -493,6 +505,7 @@ type ShowTableByIdRequest struct {
 	StartsWith *string
 	LimitFrom  *LimitFrom
 }
+
 type ShowTableRequest struct {
 	Terse       *bool
 	History     *bool
@@ -501,6 +514,7 @@ type ShowTableRequest struct {
 	StartsWith  *string
 	LimitFrom   *LimitFrom
 }
+
 type ShowTableInRequest struct {
 	Account  *bool
 	Database AccountObjectIdentifier

pkg/sdk/tables.go

@@ -226,8 +226,8 @@ type StageCopyOptionsInnerValue struct {
 }
 
 type alterTableOptions struct {
-	alter    bool                   `ddl:"static" sql:"ALTER"` //lint:ignore U1000 This is used in the ddl tag
-	table    bool                   `ddl:"static" sql:"TABLE"` //lint:ignore U1000 This is used in the ddl tag
+	alter    bool                   `ddl:"static" sql:"ALTER"`
+	table    bool                   `ddl:"static" sql:"TABLE"`
 	IfExists *bool                  `ddl:"keyword" sql:"IF EXISTS"`
 	name     SchemaObjectIdentifier `ddl:"identifier"`
 
@@ -264,7 +264,7 @@ type TableReclusterAction struct {
 
 type TableReclusterChangeState struct {
 	State     *ReclusterState `ddl:"keyword"`
-	recluster bool            `ddl:"static" sql:"RECLUSTER"` //lint:ignore U1000 This is used in the ddl tag
+	recluster bool            `ddl:"static" sql:"RECLUSTER"`
 }
 
 type ReclusterState string
@@ -343,22 +343,22 @@ type TableColumnAlterUnsetMaskingPolicyAction struct {
 }
 
 type TableColumnAlterSetTagsAction struct {
-	alter      bool             `ddl:"static" sql:"ALTER COLUMN"` //lint:ignore U1000 This is used in the ddl tag
+	alter      bool             `ddl:"static" sql:"ALTER COLUMN"`
 	ColumnName string           `ddl:"keyword"`
-	set        bool             `ddl:"static" sql:"SET"` //lint:ignore U1000 This is used in the ddl tag
+	set        bool             `ddl:"static" sql:"SET"`
 	Tags       []TagAssociation `ddl:"keyword" sql:"TAG"`
 }
 
 type TableColumnAlterUnsetTagsAction struct {
-	alter      bool               `ddl:"static" sql:"ALTER COLUMN"` //lint:ignore U1000 This is used in the ddl tag
+	alter      bool               `ddl:"static" sql:"ALTER COLUMN"`
 	ColumnName string             `ddl:"keyword"`
-	unset      bool               `ddl:"static" sql:"UNSET"` //lint:ignore U1000 This is used in the ddl tag
+	unset      bool               `ddl:"static" sql:"UNSET"`
 	Tags       []ObjectIdentifier `ddl:"keyword" sql:"TAG"`
 }
 
 type TableColumnAlterDropColumns struct {
-	dropColumn bool     `ddl:"static" sql:"DROP COLUMN"` //lint:ignore U1000 This is used in the ddl tag
-	Columns    []string `ddl:"keyword"`                  //lint:ignore U1000 This is used in the ddl tag
+	dropColumn bool     `ddl:"static" sql:"DROP COLUMN"`
+	Columns    []string `ddl:"keyword"`
 }
 
 type TableColumnAlterSequenceName interface {

pkg/sdk/testint/tables_integration_test.go

@@ -48,6 +48,7 @@ func TestInt_Table(t *testing.T) {
 
 		assert.Equal(t, table.Name, name)
 	})
+
 	t.Run("create table: complete optionals", func(t *testing.T) {
 		maskingPolicy, _ := createMaskingPolicyWithOptions(t, client, database, schema, []sdk.TableColumnSignature{
 			{
@@ -204,6 +205,7 @@ func TestInt_Table(t *testing.T) {
 			assert.True(t, sourceTableColumns[i] == likeTableColumns[i])
 		}
 	})
+
 	t.Run("create table clone", func(t *testing.T) {
 		sourceTable, _ := createTable(t, client, database, schema)
 		name := random.String()
@@ -419,6 +421,7 @@ func TestInt_Table(t *testing.T) {
 		err = client.Tables.Alter(ctx, alterRequest)
 		require.NoError(t, err)
 	})
+
 	t.Run("alter table: set tags", func(t *testing.T) {
 		name := random.String()
 		id := sdk.NewSchemaObjectIdentifier(database.Name, schema.Name, name)
@@ -444,6 +447,7 @@ func TestInt_Table(t *testing.T) {
 		err = client.Tables.Alter(ctx, alterRequest)
 		require.NoError(t, err)
 	})
+
 	t.Run("alter table: unset tags", func(t *testing.T) {
 		columnTags := []sdk.TagAssociationRequest{
 			{
@@ -546,6 +550,7 @@ func TestInt_Table(t *testing.T) {
 		err = client.Tables.Alter(ctx, alterRequest)
 		require.NoError(t, err)
 	})
+
 	t.Run("alter constraint: alter", func(t *testing.T) {
 		name := random.String()
 		id := sdk.NewSchemaObjectIdentifier(database.Name, schema.Name, name)
@@ -826,6 +831,7 @@ func TestInt_Table(t *testing.T) {
 		assert.Empty(t, table2.Owner)
 		require.NoError(t, err)
 	})
+
 	t.Run("with starts with", func(t *testing.T) {
 		table, tableCleanup := createTable(t, client, database, schema)
 		t.Cleanup(tableCleanup)
@@ -837,6 +843,7 @@ func TestInt_Table(t *testing.T) {
 		assert.NotEmpty(t, table2.Owner)
 		require.NoError(t, err)
 	})
+
 	t.Run("when searching a non-existent table", func(t *testing.T) {
 		tables, err := client.Tables.Show(ctx, sdk.NewShowTableRequest().WithLikePattern("non-existent"))
 		require.NoError(t, err)