wip

docs/resources/grant_privileges_to_database_role.md

@@ -245,7 +245,7 @@ where:
 - grant_type - enum
 - grant_data - enum data
 
-It has varying number of parts, depending on <grant_type>. All the possible types are:
+It has varying number of parts, depending on grant_type. All the possible types are:
 
 ### OnDatabase
 `terraform import "<database_role_name>|<with_grant_option>|<always_apply>|<privileges>|OnDatabase|<database_name>"`

pkg/resources/grant_privileges_to_database_role.go

@@ -4,14 +4,15 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"slices"
+	"strings"
+
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/go-uuid"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
-	"slices"
-	"strings"
 )
 
 // TODO: Imported privileges (after second account will be added)
@@ -645,7 +646,7 @@ func ReadGrantPrivilegesToDatabaseRole(ctx context.Context, d *schema.ResourceDa
 		if id.WithGrantOption == grant.GrantOption && id.DatabaseRoleName.Name() == grant.GranteeName.Name() {
 			// Future grants do not have grantedBy, only current grants do.
 			// If grantedby is an empty string, it means terraform could not have created the grant
-			if (opts.Future == nil || *opts.Future == false) && grant.GrantedBy.Name() == "" {
+			if (opts.Future == nil || !*opts.Future) && grant.GrantedBy.Name() == "" {
 				continue
 			}
 			// grant_on is for future grants, granted_on is for current grants.

pkg/resources/grant_privileges_to_database_role_acceptance_test.go

@@ -4,15 +4,16 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"regexp"
+	"testing"
+
 	acc "github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/acceptance"
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
 	"github.com/hashicorp/terraform-plugin-testing/config"
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/plancheck"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 	"github.com/hashicorp/terraform-plugin-testing/tfversion"
-	"regexp"
-	"testing"
 )
 
 func TestAcc_GrantPrivilegesToDatabaseRole_OnDatabase(t *testing.T) {

pkg/resources/grant_privileges_to_database_role_identifier.go

@@ -2,10 +2,11 @@ package resources
 
 import (
 	"fmt"
-	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/helpers"
-	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
 	"strconv"
 	"strings"
+
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/helpers"
+	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
 )
 
 type DatabaseRoleGrantKind string

pkg/resources/grant_privileges_to_database_role_identifier_test.go

@@ -1,9 +1,10 @@
 package resources
 
 import (
+	"testing"
+
 	"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 func TestParseGrantPrivilegesToDatabaseRoleId(t *testing.T) {

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_AlwaysApply/test.tf

@@ -1,6 +1,6 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  all_privileges = var.all_privileges
-  on_database = "\"${var.database}\""
-  always_apply = var.always_apply
+  all_privileges     = var.all_privileges
+  on_database        = "\"${var.database}\""
+  always_apply       = var.always_apply
 }

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnAllSchemasInDatabase/test.tf

@@ -1,7 +1,7 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  with_grant_option  = var.with_grant_option
 
   on_schema {
     all_schemas_in_database = "\"${var.database}\""

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnDatabase/test.tf

@@ -1,6 +1,6 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  on_database = "\"${var.database}\""
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  on_database        = "\"${var.database}\""
+  with_grant_option  = var.with_grant_option
 }

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnFutureSchemasInDatabase/test.tf

@@ -1,7 +1,7 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  with_grant_option  = var.with_grant_option
 
   on_schema {
     future_schemas_in_database = "\"${var.database}\""

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnSchema/test.tf

@@ -1,7 +1,7 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  with_grant_option  = var.with_grant_option
 
   on_schema {
     schema_name = "\"${var.database}\".\"${var.schema}\""

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnSchemaObject_OnAll_InDatabase/test.tf

@@ -1,12 +1,12 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  with_grant_option  = var.with_grant_option
 
   on_schema_object {
     all {
       object_type_plural = "TABLES"
-      in_database = "\"${var.database}\""
+      in_database        = "\"${var.database}\""
     }
   }
 }

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnSchemaObject_OnFuture_InDatabase/test.tf

@@ -1,12 +1,12 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  with_grant_option  = var.with_grant_option
 
   on_schema_object {
     future {
       object_type_plural = "TABLES"
-      in_database = "\"${var.database}\""
+      in_database        = "\"${var.database}\""
     }
   }
 }

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_OnSchemaObject_OnObject/test.tf

@@ -10,10 +10,10 @@ resource "snowflake_table" "test" {
 }
 
 resource "snowflake_grant_privileges_to_database_role" "test" {
-  depends_on = [snowflake_table.test]
+  depends_on         = [snowflake_table.test]
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  with_grant_option = var.with_grant_option
+  privileges         = var.privileges
+  with_grant_option  = var.with_grant_option
 
   on_schema_object {
     object_type = "TABLE"

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_UpdatePrivileges/all_privileges/test.tf

@@ -1,5 +1,5 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  all_privileges = var.all_privileges
-  on_database = "\"${var.database}\""
+  all_privileges     = var.all_privileges
+  on_database        = "\"${var.database}\""
 }

pkg/resources/testdata/TestAcc_GrantPrivilegesToDatabaseRole_UpdatePrivileges/privileges/test.tf

@@ -1,5 +1,5 @@
 resource "snowflake_grant_privileges_to_database_role" "test" {
   database_role_name = "\"${var.database}\".\"${var.name}\""
-  privileges = var.privileges
-  on_database = "\"${var.database}\""
+  privileges         = var.privileges
+  on_database        = "\"${var.database}\""
 }