feat: grant privileges to database role resource #251
sfc-gh-jcieslakreviewdog-golanglint-ci.yml
on: pull_request
reviewdog
1m 58s
Annotations
10 errors
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L73
[golangci] reported by reviewdog 🐶
commentFormatting: put a space between `//` and comment text (gocritic)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:73:3: commentFormatting: put a space between `//` and comment text (gocritic)
//},
^
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L6
[golangci] reported by reviewdog 🐶
File is not `gofumpt`-ed (gofumpt)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:6: File is not `gofumpt`-ed (gofumpt)
"fmt"
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L13
[golangci] reported by reviewdog 🐶
File is not `gofumpt`-ed (gofumpt)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:13: File is not `gofumpt`-ed (gofumpt)
"log"
"slices"
"strings"
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role_identifier.go#L4
[golangci] reported by reviewdog 🐶
File is not `gofumpt`-ed (gofumpt)
Raw Output:
pkg/resources/grant_privileges_to_database_role_identifier.go:4: File is not `gofumpt`-ed (gofumpt)
"fmt"
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role_identifier.go#L5
[golangci] reported by reviewdog 🐶
File is not `goimports`-ed (goimports)
Raw Output:
pkg/resources/grant_privileges_to_database_role_identifier.go:5: File is not `goimports`-ed (goimports)
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/helpers"
"github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk"
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L665
[golangci] reported by reviewdog 🐶
S1002: should omit comparison to bool constant, can be simplified to `!*opts.Future` (gosimple)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:665:30: S1002: should omit comparison to bool constant, can be simplified to `!*opts.Future` (gosimple)
if (opts.Future == nil || *opts.Future == false) && grant.GrantedBy.Name() == "" {
^
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L363
[golangci] reported by reviewdog 🐶
SA5000: assignment to nil map (staticcheck)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:363:4: SA5000: assignment to nil map (staticcheck)
onSchema["schema_name"] = data.SchemaName.FullyQualifiedName()
^
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L365
[golangci] reported by reviewdog 🐶
SA5000: assignment to nil map (staticcheck)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:365:4: SA5000: assignment to nil map (staticcheck)
onSchema["all_schemas_in_database"] = data.DatabaseName.FullyQualifiedName()
^
|
|
reviewdog:
pkg/resources/grant_privileges_to_database_role.go#L367
[golangci] reported by reviewdog 🐶
SA5000: assignment to nil map (staticcheck)
Raw Output:
pkg/resources/grant_privileges_to_database_role.go:367:4: SA5000: assignment to nil map (staticcheck)
onSchema["future_schemas_in_database"] = data.DatabaseName.FullyQualifiedName()
^
|
|
reviewdog
reviewdog exited with status code: 1
|