-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorporating forked changes along with github actions updates #303
Conversation
# Conflicts: # schemachange/session/Credential.py # schemachange/session/SnowflakeSession.py
…guments, comment later removals
Feat/integrate connections toml
* Update github actions for Development Workflow to match new Connections options. * Added fully_qualified_schema_name in CreateChangeHistoryTable class to allow creation of schema with fully qualified name. * Added script file to use in multiple workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! Thank you @sfc-gh-tmathew and @zanebclark for the excellent work here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-tmathew after this update I m getting “password is empty error “ in my circle ci pipeline. till 20th Nov it was working fine from 25nov I m seeing this error.
Im using cloud formation template and not terraform.
@sfc-gh-twhite @sfc-gh-tmathew @jeremiahhansen @zanebclark . Need your help. After this update my pipe is giving password is empty error and I m unable to resolve it. I m using yml config and not toml file for connection. |
Hey @faisalgen, sorry for the delay here. @sfc-gh-tmathew and I started looking at why this is happening; we've got to add some tests to ensure we're covering all of the scenarios for the different configurations that can be used to provide a password. In the meantime, can you install schemachange from PyPI in your CI process? The official release generally tends to be a bit more stable than the master branch in the repo. |
No description provided.