Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorporating forked changes along with github actions updates #303

Merged
merged 37 commits into from
Nov 22, 2024

Conversation

sfc-gh-tmathew
Copy link
Collaborator

No description provided.

Zane added 30 commits October 18, 2024 15:41
# Conflicts:
#	schemachange/session/Credential.py
#	schemachange/session/SnowflakeSession.py
Zane Clark and others added 7 commits November 14, 2024 11:04
* Update github actions for Development Workflow to match new Connections options.
* Added fully_qualified_schema_name in CreateChangeHistoryTable class to allow creation of schema with fully qualified name.
* Added script file to use in multiple workflows.
Copy link
Collaborator

@sfc-gh-twhite sfc-gh-twhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thank you @sfc-gh-tmathew and @zanebclark for the excellent work here!

populateConnection.sh Show resolved Hide resolved
@sfc-gh-tmathew sfc-gh-tmathew merged commit 99ff357 into master Nov 22, 2024
4 checks passed
Copy link

@faisalgen faisalgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-tmathew after this update I m getting “password is empty error “ in my circle ci pipeline. till 20th Nov it was working fine from 25nov I m seeing this error.
Im using cloud formation template and not terraform.

@faisalgen
Copy link

faisalgen commented Dec 5, 2024

@sfc-gh-twhite @sfc-gh-tmathew @jeremiahhansen @zanebclark . Need your help. After this update my pipe is giving password is empty error and I m unable to resolve it. I m using yml config and not toml file for connection.

@sfc-gh-twhite
Copy link
Collaborator

@sfc-gh-twhite @sfc-gh-tmathew @jeremiahhansen @zanebclark . Need your help. After this update my pipe is giving password is empty error and I m unable to resolve it. I m using yml config and not toml file for connection.

Hey @faisalgen, sorry for the delay here. @sfc-gh-tmathew and I started looking at why this is happening; we've got to add some tests to ensure we're covering all of the scenarios for the different configurations that can be used to provide a password.

In the meantime, can you install schemachange from PyPI in your CI process? The official release generally tends to be a bit more stable than the master branch in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants