R__ and V__ Script change list. Reopening after bugfix merge #150
Conversation
README.md
Outdated
| @@ -385,6 +385,7 @@ Parameter | Description | |||
| --dry-run | Run schemachange in dry run mode. The default is 'False'. | |||
| --query-tag | A string to include in the QUERY_TAG that is attached to every SQL statement executed. | |||
| --oauth-config | Define values for the variables to Make Oauth Token requests (e.g. {"token-provider-url": "https//...", "token-request-payload": {"client_id": "GUID_xyz",...},... })' | |||
| -cfl --change-file-list | Comma delimited list of files, full path, that schemachange will filter to when deploying V and R scripts. | |||
There was a problem hiding this comment.
By "filter", is it filter out? meaning it will not check for the files on this list? Or vice versa? I think you could make this sentence clearer on the flag's purpose
|
@eaguilera23 I updated the readme and the argeparse help value. |
|
@sfc-gh-jhansen Were there other items that needed to be addressed for this? |
|
Here there @CermitDFrog, sorry for the delay here. I've just been slammed with work lately and haven't had time to test/review this. Hoping to get to this in the next few days 🤞 . |
|
Probably something that could wait to be a follow-up, but thoughts on the flag accepting a pattern and using a more common flag name like |
|
Hello @afeld, Thank you for bringing up the idea. Could you open a new issue and describe the |
|
Hello @CermitDFrog We have started reviewing open issues and PRs. This PR still has merge conflicts. Could you help again by taking a look and see if you can resolve your fixes to the latest release ? Thank you for your contributions! |
|
This should be closed. Due to slow response times back then I just forked the repo and used my own branch at work. I may pick this up, but I would need to re-familiarize with the current code as it looks like it's gone through a major refactor. |
My original PR for this closed when I merged the bugfix from PR 149 into my fork. This is just reopening after resolving any conflicts from bugfix to my branch.
Issue: 148
Original PR: PR 145
@sfc-gh-jhansen Versions and such are all up to date.