Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.5.1 broke for all deployments with Verbose logging and R__ scripts #151

Closed
CermitDFrog opened this issue Feb 13, 2023 · 3 comments

Comments

@CermitDFrog
Copy link

On line 544 there is a log for R__ scripts that are skipped. With 3.5.0/5.1 there was a change that resulted in the parameter not being passed correctly for format. Now all our deployments are getting a key error and halting on this line.

image

Correction should be to switch line 544 to the following

          print(_log_skip_r.format(**script))

I can't make a PR without destroying my current branch and PR, but I will be including this change in my branch.

@CermitDFrog
Copy link
Author

PR 150 includes this change as well.

@CermitDFrog
Copy link
Author

@sfc-gh-jhansen Looks like multiple folks have run into this issue. Could we get my PR merged to resolve?

I had to revert my production usage version back to 3.4.2 in the meantime.

@CermitDFrog CermitDFrog changed the title Version 5.1 broke for all deployments with Verbose logging and R__ scripts Version 3.5.1 broke for all deployments with Verbose logging and R__ scripts Feb 14, 2023
@sfc-gh-jhansen
Copy link
Collaborator

Just released 3.5.2 with only the verbose logging fix for now. I just didn't have time tonight to think about and test out your new changes. But I will shortly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants