Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for YouTube shorts in the YouTube regexp #619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zingzy
Copy link

@Zingzy Zingzy commented Oct 1, 2024

This PR addresses issue #206

Overview

  • Update the regex to add support for YouTube shorts

Testing

Screenshot 2024-09-29 023356

Copy link

vercel bot commented Oct 1, 2024

@Zingzy is attempting to deploy a commit to the snailedlt's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Owner

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you please also add some new URLs to the test file? 😊

@Zingzy
Copy link
Author

Zingzy commented Oct 2, 2024

Thanks for the PR!

Could you please also add some new URLs to the test file? 😊

Sure, just needed a confirmation I need to add the URLs in this file right?

@Zingzy
Copy link
Author

Zingzy commented Oct 2, 2024

@Snailedlt I added the new URLs in the test file, please check

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
markdown-videos-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 11:45am
markdown-videos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 11:45am

@Snailedlt
Copy link
Owner

@Zingzy doesn't work in the preview environment for some reason Screenshot_2024_1003_153009.png

@Zingzy
Copy link
Author

Zingzy commented Oct 3, 2024

@Zingzy doesn't work in the preview environment for some reason Screenshot_2024_1003_153009.png

Hello @Snailedlt I am extremely sorry, I might have pushed some different branch, I will re-evaluate every test and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants