Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: delete dead clients from epoll #741

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

Drakulix
Copy link
Member

I am not sure, if we need to do the same thing here for kqueue, I only observed this problem on an epoll system, but I figured it can't hurt.

This fixes a deadlock from killed clients blocking the loop in dispatch_all_clients for the rust-backend.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.84%. Comparing base (1f6f4f5) to head (4108eea).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   73.11%   75.84%   +2.72%     
==========================================
  Files          45       46       +1     
  Lines        8183     8226      +43     
==========================================
+ Hits         5983     6239     +256     
+ Misses       2200     1987     -213     
Flag Coverage Δ
main 58.90% <100.00%> (-0.02%) ⬇️
test-- 81.09% <100.00%> (?)
test--server_system 64.69% <0.00%> (?)
test-client_system- 72.10% <100.00%> (?)
test-client_system-server_system 54.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants