Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #52

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Improvements #52

merged 6 commits into from
Apr 25, 2024

Conversation

BTOdell
Copy link
Contributor

@BTOdell BTOdell commented Apr 23, 2024

No description provided.

@BTOdell
Copy link
Contributor Author

BTOdell commented Apr 24, 2024

I just fixed a bug in the NMS algorithm. The old algorithm implementation was producing results like:

image

and the new implementation is producing results like:

image

Sorry the uploaded image quality is poor, but the bounding boxes towards the top of the screen are heavily duplicated and overlapping. The NMS algorithm should be cleaning these up but were not.

@Smirkey Smirkey changed the base branch from main to start/using-views April 25, 2024 11:58
@Smirkey
Copy link
Owner

Smirkey commented Apr 25, 2024

thanks a lot for the changes !

I think it won't be practical to handle this in a single PR (moving from owned arrays to views)
I changed the base branch to a dev branch

@BTOdell
Copy link
Contributor Author

BTOdell commented Apr 25, 2024

I only opened this PR to provide a reference into my fork. I don't plan on making further changes to my fork to fix the CI errors. I encourage you to just use my fork as a reference to make the changes across the entire project. My fork only has made the changes for a few select functions that I needed to use.

@BTOdell
Copy link
Contributor Author

BTOdell commented Apr 25, 2024

I'd be happy to answer any questions about why I made certain changes. I haven't run any benchmarks on the new code, so for all I know my implementation could be slower than yours. I was going for correctness as top priority.

@Smirkey Smirkey marked this pull request as ready for review April 25, 2024 21:27
@Smirkey Smirkey merged commit 7181977 into Smirkey:start/using-views Apr 25, 2024
6 of 22 checks passed
@Smirkey
Copy link
Owner

Smirkey commented Apr 25, 2024

you're right !
As for speed, using views is the way to go and I believe that it'll bring significant speedups specifically in python
there are automated benchmarks in the CI that will run when the tests will pass.

Thanks you very much for this work, I'll make the other necessary changes in the feature branch I created

Repository owner deleted a comment from Buillaume Apr 25, 2024
Smirkey added a commit that referenced this pull request Apr 30, 2024
* Improvements (#52)

* chore: use views in all functions (#55)

* chore: integrate changes to python bindings
...
---------

Co-authored-by: Bradley Odell <btodell@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants