-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements #52
Improvements #52
Conversation
I just fixed a bug in the NMS algorithm. The old algorithm implementation was producing results like: and the new implementation is producing results like: Sorry the uploaded image quality is poor, but the bounding boxes towards the top of the screen are heavily duplicated and overlapping. The NMS algorithm should be cleaning these up but were not. |
thanks a lot for the changes ! I think it won't be practical to handle this in a single PR (moving from owned arrays to views) |
I only opened this PR to provide a reference into my fork. I don't plan on making further changes to my fork to fix the CI errors. I encourage you to just use my fork as a reference to make the changes across the entire project. My fork only has made the changes for a few select functions that I needed to use. |
I'd be happy to answer any questions about why I made certain changes. I haven't run any benchmarks on the new code, so for all I know my implementation could be slower than yours. I was going for correctness as top priority. |
you're right ! Thanks you very much for this work, I'll make the other necessary changes in the feature branch I created |
No description provided.