Fix adjoint memory leak in ExpressionGraph #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
fix-adjoint-memleak-in-expression-graph
branch
4 times, most recently
from
0dc407a to
f15c9b0
Compare
There was a circular reference between adjoints and their parent expressions that prevented them from being freed. The adjoints are now unlinked when they're no longer needed. The Hessian tests were instrumented to confirm all Expressions were freed at the end of each test. PoolResource and PoolAllocator were restructured to take the chunk size at runtime for ease of use, and the default chunk size was reduced to 16384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a circular reference between adjoints and their parent expressions that prevented them from being freed. The adjoints are now unlinked when they're no longer needed.
The Hessian tests were instrumented to confirm all Expressions were freed at the end of each test.
PoolResource and PoolAllocator were restructured to take the chunk size at runtime for ease of use, and the default chunk size was reduced to 16384.