Use small_vector implementation ubsan is happy with

LLVM's SmallVector threw maybe-uninitialized warnings in GCC 14.
SleipnirGroup · Jun 16, 2024 · 55dba78 · 55dba78
1 parent b699579
commit 55dba78
Show file tree

Hide file tree

Showing 17 changed files with 4,416 additions and 181 deletions.
diff --git a/include/.styleguide b/include/.styleguide
@@ -6,6 +6,10 @@ cppSrcFileInclude {
   \.cpp$
 }
 
+licenseUpdateExclude {
+  include/sleipnir/util/small_vector\.hpp$
+}
+
 includeOtherLibs {
   ^Eigen/
 }
diff --git a/include/sleipnir/autodiff/Expression.hpp b/include/sleipnir/autodiff/Expression.hpp
@@ -14,8 +14,8 @@
 #include "sleipnir/autodiff/ExpressionType.hpp"
 #include "sleipnir/util/IntrusiveSharedPtr.hpp"
 #include "sleipnir/util/Pool.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir::detail {
 

diff --git a/include/sleipnir/autodiff/ExpressionGraph.hpp b/include/sleipnir/autodiff/ExpressionGraph.hpp
@@ -6,8 +6,8 @@
 
 #include "sleipnir/autodiff/Expression.hpp"
 #include "sleipnir/util/FunctionRef.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir::detail {
 

diff --git a/include/sleipnir/autodiff/Hessian.hpp b/include/sleipnir/autodiff/Hessian.hpp
@@ -12,8 +12,8 @@
 #include "sleipnir/autodiff/Profiler.hpp"
 #include "sleipnir/autodiff/Variable.hpp"
 #include "sleipnir/autodiff/VariableMatrix.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/autodiff/Jacobian.hpp b/include/sleipnir/autodiff/Jacobian.hpp
@@ -10,8 +10,8 @@
 #include "sleipnir/autodiff/Profiler.hpp"
 #include "sleipnir/autodiff/Variable.hpp"
 #include "sleipnir/autodiff/VariableMatrix.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/autodiff/VariableBlock.hpp b/include/sleipnir/autodiff/VariableBlock.hpp
@@ -218,9 +218,9 @@ class VariableBlock {
    * @param row The scalar subblock's row.
    * @param col The scalar subblock's column.
    */
-  template <typename Mat2 = Mat>
-    requires(!std::is_const_v<Mat2>)
-  Variable& operator()(int row, int col) {
+  Variable& operator()(int row, int col)
+    requires(!std::is_const_v<Mat>)
+  {
     Assert(row >= 0 && row < Rows());
     Assert(col >= 0 && col < Cols());
     return (*m_mat)(m_rowOffset + row, m_colOffset + col);
@@ -243,9 +243,9 @@ class VariableBlock {
    *
    * @param row The scalar subblock's row.
    */
-  template <typename Mat2 = Mat>
-    requires(!std::is_const_v<Mat2>)
-  Variable& operator()(int row) {
+  Variable& operator()(int row)
+    requires(!std::is_const_v<Mat>)
+  {
     Assert(row >= 0 && row < Rows() * Cols());
     return (*this)(row / Cols(), row % Cols());
   }

diff --git a/include/sleipnir/autodiff/VariableMatrix.hpp b/include/sleipnir/autodiff/VariableMatrix.hpp
@@ -16,8 +16,8 @@
 #include "sleipnir/autodiff/VariableBlock.hpp"
 #include "sleipnir/util/Assert.hpp"
 #include "sleipnir/util/FunctionRef.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/optimization/Constraints.hpp b/include/sleipnir/optimization/Constraints.hpp
@@ -8,8 +8,8 @@
 #include "sleipnir/autodiff/Variable.hpp"
 #include "sleipnir/util/Assert.hpp"
 #include "sleipnir/util/Concepts.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/optimization/Multistart.hpp b/include/sleipnir/optimization/Multistart.hpp
@@ -8,7 +8,7 @@
 
 #include "sleipnir/optimization/SolverStatus.hpp"
 #include "sleipnir/util/FunctionRef.hpp"
-#include "sleipnir/util/SmallVector.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/optimization/OptimizationProblem.hpp b/include/sleipnir/optimization/OptimizationProblem.hpp
@@ -22,8 +22,8 @@
 #include "sleipnir/optimization/SolverStatus.hpp"
 #include "sleipnir/optimization/solver/InteriorPoint.hpp"
 #include "sleipnir/util/Print.hpp"
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/util/Pool.hpp b/include/sleipnir/util/Pool.hpp
@@ -5,8 +5,8 @@
 #include <cstddef>
 #include <memory>
 
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {
 

diff --git a/include/sleipnir/util/SmallVector.hpp b/include/sleipnir/util/SmallVector.hpp
diff --git a/include/sleipnir/util/Spy.hpp b/include/sleipnir/util/Spy.hpp
@@ -8,8 +8,8 @@
 
 #include <Eigen/SparseCore>
 
-#include "sleipnir/util/SmallVector.hpp"
 #include "sleipnir/util/SymbolExports.hpp"
+#include "sleipnir/util/small_vector.hpp"
 
 namespace sleipnir {