Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge feature branch multiple-locations into main branch (multiple stories) #1574

Open
wants to merge 148 commits into
base: master
Choose a base branch
from
Open

Merge feature branch multiple-locations into main branch (multiple stories) #1574

wants to merge 148 commits into from

Conversation

killij
Copy link
Contributor

@killij killij commented Jan 24, 2025

Once merged, do not delete the feature branch as development is ongoing.

killij and others added 30 commits December 11, 2024 15:49
@killij
FAI-2100 - Create the confirm multiple locations page
c63f142
@killij
FAI-2100 - Remove address check
8101b12
@killij
FAI-2100 - Maintain the order of addresses from the previous screen
b5f99b3
@killij
FAI-2100 - Add a small margin below the addresses
e267243
@killij
FAI-2100 - Rename CSS class
1a823e6
@killij
FAI-2100 - Sonar suggestion
f738ea3
@killij
FAI-2100 - Change address html to use <p> instead of <div>
0ac6926
@killij
FAI-2098 - Add 'Select An Address' page
0d3d3ef
@killij
FAI-2098 - Add tests for the banner tag helper
e373ec9
@killij
FAI-2097 - Create the Enter Location Manually page + refactor
8f5debe
@killij
Merge pull request #1536 from SkillsFundingAgency/FAI-2100-Create-the…
24fa780 
…-confirm-multiple-locations-page

FAI-2100 - Create the confirm multiple locations page
@killij
Merge branch 'feature/multiple-locations' into FAI-2097-Create-the-En…
8002468 
…ter-New-Location-Manually-page
@killij
FAI-2097 - Adjust the Address max line length for validation
9377ea4
@killij
FAI-2097 - Remove xUnit from Employer Web UnitTests.csproj
25166da
@killij
FAI-2097 - Remove TODO. We no longer surface the map for presentation.
339cdd3
@killij
Merge branch 'feature/multiple-locations' into FAI-2098-Create-the-Se…
282f189 
…lect-an-address-page
@killij
Merge pull request #1538 from SkillsFundingAgency/FAI-2098-Create-the…
3fa885b 
…-Select-an-address-page

FAI-2098 - Create the 'Select An Address' page
@killij
Merge branch 'feature/multiple-locations' into FAI-2097-Create-the-En…
fdea3b1 
…ter-New-Location-Manually-page
@killij
FAI-2098 - Fix empty legal entity address issue
b3346a9
@killij
FAI-2098 - Strip out empty addresses
eff93c9
@killij
FAI-2101 - Update the CheckYourAnswers page for multiple locations
0d36c4c
@killij
Merge pull request #1540 from SkillsFundingAgency/FAI-2098---Fix-null…
83d2a28 
…-address-issue

FAI-2098 - Fix null address issue
@killij
Merge branch 'feature/multiple-locations' into FAI-2117---Create-the-…
7e66968 
…Recruit-Across-England-page
@killij
FAI-2117 - Add the Recruit Nationally page
3b5646d
@killij
FAI-2117 - Fix the order of the fields in the validation summary
cc29205
@killij
Merge branch 'FAI-2117---Create-the-Recruit-Across-England-page' into…
a4e2759 
… FAI-2101-Update-the-Check-your-answers-page
@killij
FAI-2101 - Fix across england check answers display
f5e19c3
@dashton82
Merge pull request #1539 from SkillsFundingAgency/FAI-2097-Create-the…
ba5c467 
…-Enter-New-Location-Manually-page

FAI-2097 - Create the enter new location manually page
@killij
Merge branch 'feature/multiple-locations' into FAI-2117---Create-the-…
358bb86 
…Recruit-Across-England-page
@killij
Merge pull request #1541 from SkillsFundingAgency/FAI-2117---Create-t…
333db5e 
…he-Recruit-Across-England-page

FAI-2117  - Create the recruit nationally page
@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 3, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 4, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@killij
Merge pull request #1578 from SkillsFundingAgency/FAI-2141---Add-the-…
1b0aab2 
…new-Multiple-Locations-fields-to-the-API-response

FAI-2141 - Add new MultipleLocations fields to the VacancyProjectionBase
@das-github-app
Copy link

das-github-app bot commented Feb 4, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 4, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 4, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 4, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 5, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

das-github-app bot commented Feb 5, 2025

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@das-github-app
Copy link

Please remember to check any packages used by this application to ensure they are up to date @killij. cc/ @ecarroll95

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.2% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killij @dashton82